[EuiComboBox] Added custom option text prop#3811
Merged
elizabetdev merged 9 commits intoelastic:masterfrom Aug 3, 2020
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3811/ |
elizabetdev
commented
Jul 28, 2020
src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
Outdated
Show resolved
Hide resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3811/ |
elizabetdev
commented
Jul 31, 2020
src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
Show resolved
Hide resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3811/ |
chandlerprall
suggested changes
Jul 31, 2020
src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
Outdated
Show resolved
Hide resolved
src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
Show resolved
Hide resolved
…ons_list.tsx Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3811/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3811/ |
chandlerprall
suggested changes
Aug 3, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
One small change to make React happy, otherwise this looks good!
src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
Outdated
Show resolved
Hide resolved
…ons_list.tsx Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3811/ |
chandlerprall
approved these changes
Aug 3, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM! Pulled & tested locally
nyurik
pushed a commit
that referenced
this pull request
Aug 18, 2020
* Added custom option text prop * Added CL number * Removing unecessary span * Adding highlight search value function * Update src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx Co-authored-by: Chandler Prall <chandler.prall@gmail.com> * Update src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3702.
This PR adds a
customOptionTextprop to EuiComboBox. Consumers can passcustomOptionText="Add {searchValue} as your occupation"to customize the custom option text.This can be tested on Single selection with custom options section.
Screenshot
Checklist
[ ] Checked in mobile[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes