Remove the popover arrow from datagrid expanded cells#3832
Merged
thompsongl merged 3 commits intoelastic:masterfrom Jul 30, 2020
Merged
Remove the popover arrow from datagrid expanded cells#3832thompsongl merged 3 commits intoelastic:masterfrom
thompsongl merged 3 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3832/ |
thompsongl
approved these changes
Jul 30, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3832/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3821
When expanding a datagrid cell, the popover's arrow was hidden due to some css rules around positioning/sizing the box. However, when the popover appears on top of the element instead of below it, the arrow's positioning put it inside the popover and increased it's scroll height. This change removes the arrow altogether.
I also fixed the schema example's initial sort column to point at a column that actually exists.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes