Prevent combobox from complaining about long search values#3797
Merged
chandlerprall merged 2 commits intoelastic:masterfrom Jul 27, 2020
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3797/ |
cchaos
approved these changes
Jul 23, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Tested this in the UI and the behavior is fixed. 🎉 The code ... 🤷♀️ 😆
thompsongl
approved these changes
Jul 27, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Code LGTM. Also doesn't appear to have affected other closeList calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3791
Turns out a very long search/custom value in the combobox triggers a
scrollevent on the input itself. This is not captured by the options list, and causes the list box to close. When the input has focus but the list box is closed, the input is considered invalid.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes