Skip to content

[EuiPagination] Fixed wrong page count with compressed#3827

Merged
thompsongl merged 3 commits intoelastic:masterfrom
crux153:3826
Jul 30, 2020
Merged

[EuiPagination] Fixed wrong page count with compressed#3827
thompsongl merged 3 commits intoelastic:masterfrom
crux153:3826

Conversation

@crux153
Copy link
Copy Markdown
Contributor

@crux153 crux153 commented Jul 30, 2020

Summary

Fix for #3826.

if (compressed) {
    const firstPageButtonCompressed = (
      <PaginationButton pageIndex={activePage} inList={false} />
    );
    const lastPageButtonCompressed = (
      <PaginationButton pageIndex={pageCount} inList={false} />
    );
}

EuiPagination was passing one based pageCount prop to PaginationButton's pageIndex prop directly, which is zero based, which caused wrong page count when used with compressed.

Before

Screen Shot 2020-07-30 at 9 08 00 PM

After

Screen Shot 2020-07-30 at 9 34 20 PM

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 30, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

thompsongl
thompsongl suggested changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @crux153

Can you please also add a changelog entry under the Bugfixes section?

@crux153
Copy link
Copy Markdown
Contributor Author

crux153 commented Jul 30, 2020

@thompsongl Done :)

@crux153 crux153 requested a review from thompsongl July 30, 2020 14:57
@thompsongl
Copy link
Copy Markdown
Contributor

thompsongl commented Jul 30, 2020

jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 30, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3827/

@thompsongl
Copy link
Copy Markdown
Contributor

thompsongl commented Jul 30, 2020

jenkins test this

thompsongl
thompsongl approved these changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the docs deployment that the correct number of pages is shown.

Will merge on green CI

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Jul 30, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3827/

@thompsongl thompsongl merged commit 3c3a19c into elastic:master Jul 30, 2020
@thompsongl thompsongl mentioned this pull request Jul 31, 2020
Merged
@chandlerprall chandlerprall mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thompsongl thompsongl thompsongl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crux153 @kibanamachine @thompsongl