Expand findTestSubject utility type#3763
Merged
thompsongl merged 4 commits intoelastic:masterfrom Jul 21, 2020
Merged
Conversation
Contributor
Author
|
jenkins test this network connection issues |
Contributor
Author
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3763/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3763/ |
chandlerprall
approved these changes
Jul 21, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM, did some local testing with these types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noticed during Kibana upgrade prep that certain uses of
findTestSubjectrequire more explicit prop typing (ReactWrapper<MyComponentProps>vsReactWrapper<{}>). This expands two functions in EUI's test utils to be acceptanyprops.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes