Add paddingSize prop to EuiCard and display example to docs#3638
Add paddingSize prop to EuiCard and display example to docs#3638andreadelrio merged 15 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
cchaos
left a comment
There was a problem hiding this comment.
Thanks for adding the display example. I agree, I don't think we need the padding one and we can eventually rely on the Playground for that.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
652dac6 to
714f9e3
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
cchaos
left a comment
There was a problem hiding this comment.
👍 Checked it locally by changing the default value of paddingSize, all the configurations still work (albeit don't all look great), but nothing breaks.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3638/ |
Summary
This PR adds the
paddingSizeprop toEuiCardand the example for thedisplayprop to the docs.Screenshot of different
paddingSizes (s, m and l)Notes:
I excluded the option for no padding from
paddingSizebecause I think given the characteristics of the component, it wouldn't make sense to have cards with no padding whatsoever.I didn't add an example for
paddingSizesince I saw that we don't usually do that (except forEuiPanel) but happy to add one if we think it's necessary.Fixes #3552
Checklist
- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes