Skip to content

Release candidate: v1.89.0#5561

Merged
siddhartha-quad merged 50 commits into
mainfrom
release-candidate
Apr 30, 2026
Merged

Release candidate: v1.89.0#5561
siddhartha-quad merged 50 commits into
mainfrom
release-candidate

Conversation

@siddhartha-quad

Copy link
Copy Markdown
Contributor

Release candidate: v1.89.0

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

sudheer-quad and others added 30 commits April 7, 2026 04:47
Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.95.0 to 1.97.3.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.95.0...service/s3/v1.97.3)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3
  dependency-version: 1.97.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…#5502)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.17.1 to 5.18.0.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](go-git/go-git@v5.17.1...v5.18.0)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-version: 5.18.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: laveen <laveenekka@google.com>
aslam-quad and others added 18 commits April 23, 2026 08:56
Co-authored-by: laveen <laveenekka@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Apr 28, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares the repository for the v1.89.0 release. It includes significant enhancements to GKE deployment capabilities, specifically around GPU and networking configurations, and introduces a new destroy command for better resource management. Additionally, it adds a new machine learning blueprint and improves the robustness of the toolkit through new quota validation logic and updated dependencies.

Highlights

  • Release Preparation: Updated version to v1.89.0 and added official binary distribution support.
  • New Functionality: Added 'destroy' command to gcluster and implemented quota validation for blueprint deployments.
  • GKE and Networking Improvements: Introduced support for GKE managed Dynamic Resource Allocation (DRANET) and updated Kueue to v0.17.1.
  • New Examples: Added a new blueprint for G4 vGPU machine learning workloads.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/cache-metadata.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Comment thread pkg/telemetry/collector_util.go Dismissed
Comment thread pkg/telemetry/collector_util.go Dismissed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several enhancements, including the addition of a 'destroy' command for the CLI, support for NVIDIA G4 vGPUs, and improved telemetry data collection. Key changes include updating the Makefile and root command to support official binary distribution flags, adding new documentation for the destroy command and G4 vGPU blueprints, and updating various module versions. Additionally, the telemetry system has been expanded to collect more detailed environment and configuration metadata, and a new quota validation tool has been implemented. I have provided feedback regarding the synchronous network initialization in the telemetry collector and a missing import in the Slurm utility script.

Comment thread pkg/telemetry/collector.go
@siddhartha-quad siddhartha-quad marked this pull request as ready for review April 29, 2026 10:52
@siddhartha-quad siddhartha-quad requested a review from a team as a code owner April 29, 2026 10:52
@siddhartha-quad siddhartha-quad requested a review from LAVEEN April 30, 2026 04:45
@siddhartha-quad siddhartha-quad merged commit 8d20b52 into main Apr 30, 2026
78 of 92 checks passed
@siddhartha-quad siddhartha-quad deleted the release-candidate branch April 30, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.