Skip to content

Cleaning Up Filestore#5542

Merged
LAVEEN merged 1 commit into
GoogleCloudPlatform:developfrom
LAVEEN:revertFS
Apr 22, 2026
Merged

Cleaning Up Filestore#5542
LAVEEN merged 1 commit into
GoogleCloudPlatform:developfrom
LAVEEN:revertFS

Conversation

@LAVEEN

@LAVEEN LAVEEN commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

This change would revert the changes in

#5315 . Would raise another PR to make a generic script and use it across all test.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on reverting network-related modifications that were part of a previous change, specifically those impacting FileStore. The changes involve cleaning up cloud build steps by removing sed commands that dynamically altered network names and standardizing network variable definitions across daily test configurations. This ensures a consistent and stable environment, preparing for subsequent new changes.

Highlights

  • Reverted Network Configuration: This pull request reverts specific network configuration changes that were previously introduced, aiming to undo the impact of a prior change.
  • Removed Dynamic Network Modification: Several sed commands responsible for dynamically modifying network names within blueprint files during cloud build steps have been removed.
  • Updated Test Network Variables: The network variable in various daily test configurations has been updated to use a more explicit naming convention, such as {{ test_name }}-net or {{ deployment_name }}-net-0.
  • Refactored Deployment Variables: The base_network_name variable within cli_deployment_vars in test files has been refactored, either by being removed or reordered, streamlining how network parameters are passed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes sed commands from Cloud Build YAML files that were used to inject network names into blueprints and updates network definitions across various daily test configurations. The review feedback identifies inconsistencies in the network naming strategy, suggesting the use of {{ deployment_name }} instead of {{ test_name }} to ensure better build isolation. Furthermore, the reviewer points out that the base_network_name variable has become redundant in several test files due to the removal of the sed logic and should be deleted to maintain a clean codebase.

Comment thread tools/cloud-build/daily-tests/tests/h4d-vm.yml
Comment thread tools/cloud-build/daily-tests/tests/h4d-vm.yml
Comment thread tools/cloud-build/daily-tests/tests/ml-a3-ultragpu-jbvms.yml
Comment thread tools/cloud-build/daily-tests/tests/ml-a3-ultragpu-slurm.yml
Comment thread tools/cloud-build/daily-tests/tests/ml-a4-highgpu-onspot-slurm.yml
Comment thread tools/cloud-build/daily-tests/tests/ml-a4-highgpu-onspot-slurm.yml
@LAVEEN LAVEEN changed the title Reverting FileStore changes to push new changes Cleaning Up Filestore Changes Apr 22, 2026
@LAVEEN LAVEEN changed the title Cleaning Up Filestore Changes Cleaning Up Filestore Apr 22, 2026
@LAVEEN LAVEEN added the release-chore To not include into release notes label Apr 22, 2026
@LAVEEN LAVEEN marked this pull request as ready for review April 22, 2026 14:56
@LAVEEN LAVEEN requested a review from a team as a code owner April 22, 2026 14:56
@LAVEEN LAVEEN enabled auto-merge (squash) April 22, 2026 14:56
@LAVEEN LAVEEN merged commit 2aabf9b into GoogleCloudPlatform:develop Apr 22, 2026
32 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants