[Telemetry] Add support to collect GCP Project Number by kadupoornima · Pull Request #5528 · GoogleCloudPlatform/cluster-toolkit

kadupoornima · 2026-04-20T05:26:15Z

This pull request enhances the Cluster Toolkit Telemetry collection mechanism by incorporating the GCP Project Number into event metadata. It introduces the necessary API dependencies and refactors existing timeout configurations to ensure consistent behaviour across the codebase. Added unit tests with appropriate mocking for the new code.

Changes:

Project Number Collection: Implemented functionality to fetch and include the Google Cloud Project Number in telemetry event metadata.
Dependency Management: Added the Google Cloud Resource Manager API client to support project metadata lookups.
Refactoring: Standardized timeout constants across the telemetry package to ensure consistent behavior and improved maintainability.

KINDLY NOTE THAT TELEMETRY DATA IS NOT BEING COLLECTED YET.

gemini-code-assist · 2026-04-20T05:29:36Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the telemetry collection mechanism by incorporating the Google Cloud Project Number into event metadata. It introduces the necessary API dependencies and refactors existing timeout configurations to ensure consistent behavior across the codebase.

Highlights

Project Number Collection: Added functionality to retrieve and include the Google Cloud Project Number in telemetry events.
Dependency Updates: Included the Google Cloud Resource Manager API client to support project metadata lookups.
Refactoring: Standardized timeout constants across the telemetry package for better maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds the ability to collect and include the GCP project number in telemetry events by integrating the Cloud Resource Manager API. It also refactors internal timeout constants and unexports several telemetry-related constants. A significant issue was identified in the new getProjectNumber function, where the error from NewProjectsClient is ignored; this could lead to a nil pointer dereference when attempting to close the client. Additionally, the implementation should verify the presence of a project ID before initializing the client to improve efficiency.

kadupoornima · 2026-04-20T06:53:34Z

/gemini review

gemini-code-assist

Code Review

This pull request adds project number retrieval to the telemetry system, introducing the getProjectNumber function, a ProjectsClientInterface for abstraction, and corresponding unit tests. It also refactors timeout constants and unexports internal configuration variables. Feedback focuses on improving code cleanliness by removing commented-out code and optimizing getProjectNumber to validate the project ID before resource initialization.

kadupoornima · 2026-04-20T07:22:49Z

/gemini review

kadupoornima · 2026-04-20T07:23:05Z

/gemini summary

gemini-code-assist

Code Review

This pull request integrates the Google Cloud Resource Manager API to include project numbers in telemetry events by adding a ProjectNumber field to the ConcordEvent struct and implementing the logic to fetch it from the blueprint. It also refactors telemetry constants and adds unit tests for the new functionality. Review feedback highlights a critical nil pointer dereference risk in the project fetching logic and suggests improving the test mocks to correctly validate error handling scenarios.

gemini-code-assist · 2026-04-20T07:24:58Z

Summary of Changes

This pull request enhances the telemetry collection mechanism by incorporating the Google Cloud Project Number into event metadata. It introduces the necessary API dependencies and refactors existing timeout configurations to ensure consistent behavior across the codebase.

Highlights

Project Number Collection: Implemented functionality to fetch and include the Google Cloud Project Number in telemetry event metadata.
Dependency Management: Added the Google Cloud Resource Manager API client to support project metadata lookups.
Refactoring: Standardized timeout constants across the telemetry package to ensure consistent behavior and improved maintainability.

Activity

Gemini Code Assist provided initial feedback on error handling and resource management.
Author addressed initial feedback regarding error handling and client initialization.
Gemini Code Assist identified a potential nil pointer dereference and issues with test mocking.
Author requested a summary of the current pull request state.

SwarnaBharathiMantena

LGTM!

base

17d332d

kadupoornima changed the title ~~[Telemetry] Add support to collect Project Number metric~~ [Telemetry] Add support to collect GCP Project Number Apr 20, 2026

gemini-code-assist Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread pkg/telemetry/collector.go Outdated

kadupoornima added 3 commits April 20, 2026 05:31

.

6a8139d

.

0f6f9d5

tests

60fc78b

gemini-code-assist Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread pkg/telemetry/collector.go Outdated

Comment thread pkg/telemetry/collector.go

tests - proper!

92ee21a

gemini-code-assist Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread pkg/telemetry/collector_util.go Outdated

Comment thread pkg/telemetry/collector_test.go

comments

cbc0a80

kadupoornima requested review from SwarnaBharathiMantena and agrawalkhushi18 April 20, 2026 07:31

kadupoornima added the release-improvements Added to release notes under the "Improvements" heading. label Apr 20, 2026

kadupoornima marked this pull request as ready for review April 20, 2026 07:31

kadupoornima requested a review from a team as a code owner April 20, 2026 07:31

Merge branch 'develop' into telemetry-11

cb2a4f8

kadupoornima enabled auto-merge (squash) April 21, 2026 05:22

.

966ca6b

SwarnaBharathiMantena approved these changes Apr 21, 2026

View reviewed changes

kadupoornima merged commit 8662442 into GoogleCloudPlatform:develop Apr 21, 2026
12 of 77 checks passed

kadupoornima deleted the telemetry-11 branch April 21, 2026 06:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Telemetry] Add support to collect GCP Project Number#5528

[Telemetry] Add support to collect GCP Project Number#5528
kadupoornima merged 8 commits into
GoogleCloudPlatform:developfrom
kadupoornima:telemetry-11

kadupoornima commented Apr 20, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Apr 20, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

kadupoornima commented Apr 20, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

kadupoornima commented Apr 20, 2026

Uh oh!

kadupoornima commented Apr 20, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot commented Apr 20, 2026

Uh oh!

SwarnaBharathiMantena left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kadupoornima commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Apr 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

kadupoornima commented Apr 20, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

kadupoornima commented Apr 20, 2026

Uh oh!

kadupoornima commented Apr 20, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot commented Apr 20, 2026

Summary of Changes

Highlights

Uh oh!

SwarnaBharathiMantena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kadupoornima commented Apr 20, 2026 •

edited

Loading