Skip to content

Add unit tests to improve coverage#5527

Merged
AdarshK15 merged 2 commits into
GoogleCloudPlatform:developfrom
AdarshK15:improve_coverage
Apr 20, 2026
Merged

Add unit tests to improve coverage#5527
AdarshK15 merged 2 commits into
GoogleCloudPlatform:developfrom
AdarshK15:improve_coverage

Conversation

@AdarshK15

@AdarshK15 AdarshK15 commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Added unit tests to improve coverage

Coverage Improvements:
hpc-toolkit/pkg/config 83.7% -> 84.4%
hpc-toolkit/pkg/inspect 86.0% -> 88.4%
hpc-toolkit/pkg/validators 46.6% -> 59.5%

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@AdarshK15 AdarshK15 added the release-chore To not include into release notes label Apr 20, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on increasing the test coverage of the codebase by introducing several new unit test files. These additions ensure that core configuration logic, validator helpers, and error handling mechanisms are properly exercised and validated, contributing to a more robust and maintainable system.

Highlights

  • Unit Test Coverage: Added comprehensive unit tests for configuration materialization and various validator components to improve overall code coverage.
  • Validator Testing: Implemented specific test suites for cloud interaction, metadata validation helpers, and semantic validation logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 20, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds extensive unit tests for the validation package, covering cloud error handling, metadata helpers, and semantic checks for unused resources. A potential issue was identified in the isVarSet helper where negative numbers are treated as unset, which may cause RequiredValidator to fail incorrectly. It is also recommended to add positive test cases for the semantic validators to ensure that correctly referenced module outputs do not trigger false positive errors.

Comment thread pkg/validators/metadata_validator_helpers_test.go Outdated
Comment thread pkg/validators/semantic_test.go
LAVEEN
LAVEEN approved these changes Apr 20, 2026
View reviewed changes

@LAVEEN LAVEEN left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdarshK15 AdarshK15 marked this pull request as ready for review April 20, 2026 04:16
@AdarshK15 AdarshK15 requested a review from a team as a code owner April 20, 2026 04:16
@AdarshK15 AdarshK15 merged commit dd840db into GoogleCloudPlatform:develop Apr 20, 2026
18 of 84 checks passed
@AdarshK15 AdarshK15 deleted the improve_coverage branch May 3, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdarshK15 @LAVEEN