Skip to content

[Telemetry] Add support to collect the orchestrator type (GKE, Slurm, VM Instance usage)#5523

Merged
kadupoornima merged 7 commits into
GoogleCloudPlatform:developfrom
kadupoornima:telemetry-10
Apr 20, 2026
Merged

[Telemetry] Add support to collect the orchestrator type (GKE, Slurm, VM Instance usage)#5523
kadupoornima merged 7 commits into
GoogleCloudPlatform:developfrom
kadupoornima:telemetry-10

Conversation

@kadupoornima

@kadupoornima kadupoornima commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request enhances Cluster Toolkit Telemetry by introducing new metrics to identify the types of orchestrator utilized within a blueprint. By analyzing the module sources against predefined patterns, the collector can now collect the orchestrator type (GKE, Slurm, VM Instance usage), providing better visibility into infrastructure usage patterns.

Changes:

  • New Telemetry Metrics: Added three new telemetry metrics: IS_GKE, IS_SLURM, and IS_VM_INSTANCE to understand the usage distribution.
  • Module Pattern Matching: Implemented utility functions to identify if a blueprint contains modules matching specific patterns for GKE, Slurm, and VM instances.
  • Test Coverage: Updated existing telemetry tests and added new unit tests to verify the accurate detection of GKE, Slurm, and VM instance modules.

KINDLY NOTE THAT TELEMETRY DATA IS NOT BEING COLLECTED YET.

@gemini-code-assist

gemini-code-assist Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the telemetry collection capabilities of the Cluster Toolkit by introducing new metrics to identify the types of modules utilized within a blueprint. By analyzing the module sources against predefined patterns, the collector can now report whether a deployment involves GKE, Slurm, or standard VM instances, providing better visibility into infrastructure usage patterns.

Highlights

  • New Telemetry Metrics: Added three new telemetry metrics: IS_GKE, IS_SLURM, and IS_VM_INSTANCE to track the usage of these specific module types in blueprints.
  • Module Pattern Matching: Implemented utility functions to identify if a blueprint contains modules matching specific patterns for GKE, Slurm, and VM instances.
  • Test Coverage: Updated existing telemetry tests and added new unit tests to verify the accurate detection of GKE, Slurm, and VM instance modules.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@kadupoornima kadupoornima added the release-improvements Added to release notes under the "Improvements" heading. label Apr 17, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 17, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new telemetry fields to identify if a blueprint contains GKE, Slurm, or VM Instance modules. It updates the collector to extract these details and includes comprehensive unit tests. Feedback focuses on improving the efficiency of pattern matching by replacing regex with substring checks, adhering to Go naming conventions for unexported variables, adding necessary documentation comments, and optimizing slice allocations in utility functions.

Comment thread pkg/telemetry/collector_util.go
Comment thread pkg/telemetry/collector.go Outdated
Comment thread pkg/telemetry/collector.go Outdated
Comment thread pkg/telemetry/collector_util.go Outdated
@kadupoornima kadupoornima changed the title base [Telemetry] Add support to identify GKE, Slurm, and VM Instance usage Apr 17, 2026
@kadupoornima kadupoornima changed the title [Telemetry] Add support to identify GKE, Slurm, and VM Instance usage [Telemetry] Add support to report GKE, Slurm, and VM Instance usage Apr 17, 2026
@kadupoornima kadupoornima marked this pull request as ready for review April 17, 2026 11:55
@kadupoornima kadupoornima requested a review from a team as a code owner April 17, 2026 11:55
@kadupoornima kadupoornima changed the title [Telemetry] Add support to report GKE, Slurm, and VM Instance usage [Telemetry] Add support to collect the orchestrator type (GKE, Slurm, VM Instance usage) Apr 17, 2026
@kadupoornima kadupoornima enabled auto-merge (squash) April 20, 2026 11:03
@kadupoornima kadupoornima merged commit f46357d into GoogleCloudPlatform:develop Apr 20, 2026
12 of 77 checks passed
@kadupoornima kadupoornima deleted the telemetry-10 branch April 20, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agrawalkhushi18 agrawalkhushi18 agrawalkhushi18 approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena Awaiting requested review from SwarnaBharathiMantena

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadupoornima @agrawalkhushi18