Add Workflow to filter spot zones#5548
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new automated workflow designed to improve the reliability of integration tests by ensuring that target GCP zones support the necessary infrastructure dependencies. By dynamically scanning test configurations and verifying resource availability against GCP APIs, the workflow proactively filters out incompatible zones, preventing deployment failures caused by missing infrastructure features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Cloud Build configuration, filter-zone-options.yaml, which automates the filtering of GCP zones for daily tests based on resource requirements such as Filestore, Managed Lustre, and specific CPU machine types. The review identifies a critical bug in the Filestore location retrieval format and suggests several improvements, including broadening the CPU machine type regex to support more machine families, parameterizing the hardcoded GCS bucket for better flexibility, and extracting the extensive inline shell script into a separate file to improve maintainability.
81d452f
into
GoogleCloudPlatform:develop
Summary
The current workflow just creates list of zones with available capacity for accelerator types, but doesn't filter zones which doesn't have other required infrastructure dependencies.
Adds
tools/cloud-build/filter-zone-options.yamlto dynamically update integration test options files in GCS.The workflow:
This prevents deployments from failing due to unsupported features in the target zone.