Skip to content

[Telemetry] Add support to collect the Billing Account ID metric#5519

Merged
kadupoornima merged 9 commits into
GoogleCloudPlatform:developfrom
kadupoornima:telemetry-9
Apr 21, 2026
Merged

[Telemetry] Add support to collect the Billing Account ID metric#5519
kadupoornima merged 9 commits into
GoogleCloudPlatform:developfrom
kadupoornima:telemetry-9

Conversation

@kadupoornima

@kadupoornima kadupoornima commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request introduces the capability to capture and report the GCP billing account ID associated with a project within the Cluster Toolkit Telemetry system. This change involves integrating the Google Cloud Billing API, updating the telemetry metadata structure, and ensuring the new data point is correctly extracted and included in event reporting.

Changes:

  • Dependency Update: Added the cloud.google.com/go/billing library to the project dependencies.
  • Telemetry Enhancement: Implemented functionality to fetch and include the GCP billing account ID in telemetry data.
  • Refactoring: Updated the blueprint key retrieval logic and added unit tests for the new billing account ID extraction.

KINDLY NOTE THAT TELEMETRY DATA IS NOT BEING COLLECTED YET.

@kadupoornima kadupoornima added the release-improvements Added to release notes under the "Improvements" heading. label Apr 17, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability to capture and report the GCP billing account ID associated with a project within the telemetry system. This change involves integrating the Google Cloud Billing API, updating the telemetry metadata structure, and ensuring the new data point is correctly extracted and included in event reporting.

Highlights

  • Dependency Update: Added the cloud.google.com/go/billing library to the project dependencies.
  • Telemetry Enhancement: Implemented functionality to fetch and include the GCP billing account ID in telemetry data.
  • Refactoring: Updated the blueprint key retrieval logic and added unit tests for the new billing account ID extraction.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@kadupoornima kadupoornima changed the title billing account id [Telemetry] Add support to collect the Billing Account ID metric Apr 17, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 17, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the collection of Google Cloud billing account IDs for telemetry. It adds the necessary Cloud Billing API dependencies, updates the telemetry collector to retrieve and include the billing account ID in Concord events, and provides unit tests for the new functionality. A review comment suggests adding a timeout to the synchronous network call used to fetch the billing account ID to ensure the CLI remains responsive during network delays.

Comment thread pkg/telemetry/collector.go Outdated
@kadupoornima kadupoornima marked this pull request as ready for review April 17, 2026 07:59
@kadupoornima kadupoornima requested a review from a team as a code owner April 17, 2026 07:59
SwarnaBharathiMantena
SwarnaBharathiMantena reviewed Apr 21, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR also include an update to the README file of Telemetry?

Comment thread pkg/telemetry/collector.go
Comment thread pkg/telemetry/collector_util.go
Comment thread pkg/telemetry/collector_util.go
@kadupoornima

kadupoornima commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

Should this PR also include an update to the README file of Telemetry?

Not required, this is just another metric.

@kadupoornima kadupoornima enabled auto-merge (squash) April 21, 2026 06:36
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Apr 21, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

auto-merge was automatically disabled April 21, 2026 06:46

Repository rule violations found

@kadupoornima kadupoornima merged commit 588ff1b into GoogleCloudPlatform:develop Apr 21, 2026
14 of 79 checks passed
@kadupoornima kadupoornima deleted the telemetry-9 branch April 21, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@agrawalkhushi18 agrawalkhushi18 Awaiting requested review from agrawalkhushi18

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadupoornima @SwarnaBharathiMantena