Skip to content

Deprecate kubectl submodule#5537

Merged
agrawalkhushi18 merged 1 commit into
GoogleCloudPlatform:developfrom
agrawalkhushi18:deprecate-kubectl
Apr 23, 2026
Merged

Deprecate kubectl submodule#5537
agrawalkhushi18 merged 1 commit into
GoogleCloudPlatform:developfrom
agrawalkhushi18:deprecate-kubectl

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

This PR deprecates kubectl submodule as an effort to remove third-party dependency for kubectl-apply module.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@agrawalkhushi18 agrawalkhushi18 added the release-deprecations Added to release notes under the "Deprecations" heading. label Apr 21, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request deprecates and removes the kubectl submodule from the kubectl-apply module. This change is part of an ongoing effort to reduce third-party dependencies within the project.

Highlights

  • Submodule Removal: The kubectl submodule has been completely removed from the kubectl-apply module.
  • Dependency Cleanup: Removed the kubectl provider configuration and requirement from the module's version and provider definitions.
  • Documentation Update: Updated the main README to reflect the removal of the kubectl requirement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 21, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the kubectl provider and its associated manifest application logic from the kubectl-apply module, including the deletion of the main.tf and variables.tf files and the removal of the provider from versions.tf and providers.tf. I have no feedback to provide.

@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review April 23, 2026 09:10
@agrawalkhushi18 agrawalkhushi18 requested a review from a team as a code owner April 23, 2026 09:10
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Apr 23, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrawalkhushi18 agrawalkhushi18 merged commit b47a5f0 into GoogleCloudPlatform:develop Apr 23, 2026
19 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-deprecations Added to release notes under the "Deprecations" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agrawalkhushi18 @SwarnaBharathiMantena