Skip to content

fix: Resolve transient kueue webhook failures#5549

Merged
agrawalkhushi18 merged 5 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:kueue-webhook
Apr 28, 2026
Merged

fix: Resolve transient kueue webhook failures#5549
agrawalkhushi18 merged 5 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:kueue-webhook

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented Apr 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR resolves the transient kueue webhook failure where a race condition frequently occurs when Terraform attempts to apply Kueue custom resources (such as ResourceFlavor or ClusterQueue) using kueue config file before the kueue webhook is fully provisioned.

This happens because Kueue requires a few extra seconds to fully boot its internal systems in the background.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@agrawalkhushi18 agrawalkhushi18 added the release-chore To not include into release notes label Apr 23, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses transient failures occurring during the Kueue webhook installation process. By introducing a mandatory wait period after the installation module, the configuration phase is delayed, allowing the webhook service sufficient time to initialize and stabilize, thereby preventing race conditions.

Highlights

  • Added Time Provider: Introduced the hashicorp/time provider to the Terraform configuration to manage resource timing.
  • Implemented Webhook Delay: Added a 60-second sleep resource to ensure the Kueue webhook is fully ready before proceeding with configuration.
  • Updated Dependencies: Modified the Kueue configuration module to depend on the new sleep resource instead of the installation module directly.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 23, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a 60-second wait period using the time_sleep resource to allow the Kueue webhook to become ready before configuration. It also updates the module's dependencies and documentation to include the time provider. A review comment suggests applying a conditional count to the time_sleep resource so that the delay is only triggered when Kueue is actually being installed, avoiding unnecessary wait times for other configurations.

Comment thread modules/management/kubectl-apply/main.tf
@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review April 27, 2026 06:24
@agrawalkhushi18 agrawalkhushi18 requested a review from a team as a code owner April 27, 2026 06:24
SwarnaBharathiMantena
SwarnaBharathiMantena reviewed Apr 27, 2026
View reviewed changes
Comment thread modules/management/kubectl-apply/main.tf
Comment thread modules/management/kubectl-apply/main.tf Outdated
Comment thread modules/management/kubectl-apply/versions.tf Outdated
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Apr 28, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agrawalkhushi18 agrawalkhushi18 merged commit ea18149 into GoogleCloudPlatform:develop Apr 28, 2026
70 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agrawalkhushi18 @SwarnaBharathiMantena