Skip to content

Add EXTENDED as option to GKE release channel#5510

Merged
sudheer-quad merged 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:feat/optional-gke-release-channel
Apr 17, 2026
Merged

Add EXTENDED as option to GKE release channel#5510
sudheer-quad merged 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:feat/optional-gke-release-channel

Conversation

@sudheer-quad

Copy link
Copy Markdown
Contributor

This PR adds EXTENDED as a configuration option for the release channel in google container cluster .

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the GKE cluster configuration to support the 'EXTENDED' release channel. By modifying the variable definitions and documentation, it ensures that users can correctly configure their clusters to utilize this specific release channel, aligning the module with current Google Cloud capabilities.

Highlights

  • GKE Release Channel Update: Added the 'EXTENDED' option to the GKE release channel configuration.
  • Documentation Improvement: Updated the variable description and README to include the new 'EXTENDED' channel and added a link to the official Google Cloud documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the external PR from external contributor label Apr 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the 'EXTENDED' release channel in the GKE cluster module by updating the README and the variable description in 'variables.tf'. A review comment suggests improving the 'release_channel' variable by adding a Terraform validation block to enforce the allowed values, which enhances the module's robustness.

Comment thread modules/scheduler/gke-cluster/variables.tf
@sudheer-quad sudheer-quad force-pushed the feat/optional-gke-release-channel branch from 4580538 to 5d5d2bb Compare April 16, 2026 07:08
@sudheer-quad sudheer-quad marked this pull request as ready for review April 16, 2026 07:30
@sudheer-quad sudheer-quad requested review from a team and samskillman as code owners April 16, 2026 07:30
@sudheer-quad sudheer-quad added the release-chore To not include into release notes label Apr 16, 2026

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sudheer-quad sudheer-quad requested a review from LAVEEN April 17, 2026 03:35
@sudheer-quad sudheer-quad merged commit 5b12cb2 into GoogleCloudPlatform:develop Apr 17, 2026
14 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants