Skip to content

Merged v1.88.0 into develop#5507

Merged
siddhartha-quad merged 5 commits into
developfrom
main
Apr 16, 2026
Merged

Merged v1.88.0 into develop#5507
siddhartha-quad merged 5 commits into
developfrom
main

Conversation

@siddhartha-quad

Copy link
Copy Markdown
Contributor

Merged v1.88.0 into develop

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Apr 16, 2026
@siddhartha-quad siddhartha-quad requested review from a team and samskillman as code owners April 16, 2026 04:39
@github-actions github-actions Bot added the external PR from external contributor label Apr 16, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine version bump for the HPC Toolkit, updating the internal version identifier from v1.87.0 to v1.88.0. This change ensures that all modules and the core configuration reflect the latest release version.

Highlights

  • Version Update: Updated the toolkit version from v1.87.0 to v1.88.0 across all module configuration files and the main configuration package.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the toolkit version from v1.87.0 to v1.88.0 across numerous Terraform modules and the Go configuration. A review comment identifies a configuration error in the resource-policy module where the provider_meta block targets the google provider instead of google-beta, which is the module's actual dependency; this needs to be corrected to ensure telemetry is properly collected.

Comment thread modules/compute/resource-policy/versions.tf
@siddhartha-quad siddhartha-quad requested a review from LAVEEN April 16, 2026 05:30
@siddhartha-quad siddhartha-quad merged commit e7f058f into develop Apr 16, 2026
20 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants