Skip to content

Release candidate: v1.88.0#5499

Merged
siddhartha-quad merged 39 commits into
mainfrom
release-candidate
Apr 16, 2026
Merged

Release candidate: v1.88.0#5499
siddhartha-quad merged 39 commits into
mainfrom
release-candidate

Conversation

@siddhartha-quad

@siddhartha-quad siddhartha-quad commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Release candidate: v1.88.0

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

dependabot Bot and others added 30 commits April 2, 2026 10:43
@dependabot
Update protobuf requirement in /community/front-end/ofe
85edb06 
Updates the requirements on [protobuf](https://github.com/protocolbuffers/protobuf) to permit the latest version.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-version: 7.34.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump github.com/go-git/go-git/v5 from 5.16.5 to 5.17.1
7df7a70 
Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.16.5 to 5.17.1.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](go-git/go-git@v5.16.5...v5.17.1)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-version: 5.17.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@aslam-quad
Update protobuf requirement from <7.0.0,>=6.31.1 to >=6.31.1,<8.0.0 i…
31fefee 
…n /community/front-end/ofe (#5441)
@aslam-quad
Bump github.com/go-git/go-git/v5 from 5.16.5 to 5.17.1 (#5450)
1a6c627
@dependabot
Bump github.com/go-jose/go-jose/v4 from 4.1.3 to 4.1.4
cd34144 
Bumps [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose) from 4.1.3 to 4.1.4.
- [Release notes](https://github.com/go-jose/go-jose/releases)
- [Commits](go-jose/go-jose@v4.1.3...v4.1.4)

---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v4
  dependency-version: 4.1.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@aslam-quad
Update go.sum
2cf2718
@aslam-quad
Merge branch 'develop' into dependabot/go_modules/github.com/go-jose/…
8445800 
…go-jose/v4-4.1.4
@aslam-quad
Bump github.com/go-jose/go-jose/v4 from 4.1.3 to 4.1.4 (#5451)
78a54c4
@kadupoornima
[Telemetry] Set up a base skeleton framework (#5455)
97e0767
@sudheer-quad
fix broken link path
4bbe7e5
@saara-tyagi27
Update auto-generated README files via pre-commit hooks (#5463)
1f8c944
@jessicaochen @vikramvs-gg
feat: plumb optional auto monitoring scope (#5331)
eb07a6a 
Co-authored-by: Vivek Vikram Singh <vikramvs@google.com>
@simrankaurb @siddhartha-quad
@saara-tyagi27 @jamOne- @aslam-quad @dependabot @vikramvs-gg @shubpal07 @agrawalkhushi18 @parulbajaj01
Integrate CHS to GKE and Slurm A3U and A4 Daily Tests (#5335)
a7b8c8d 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Siddhartha <stamatam@google.com>
Co-authored-by: saara-tyagi27 <saaratyagi@google.com>
Co-authored-by: Dominik Rabij <dominikrabij@google.com>
Co-authored-by: Aslam <aslmohammad@google.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vivek Vikram Singh <vikramvs@google.com>
Co-authored-by: Shubham Pal <shubpal@google.com>
Co-authored-by: agrawalkhushi18 <agrawalkhushi@google.com>
Co-authored-by: parulbajaj01 <parulbajaj@google.com>
@agrawalkhushi18
Modify the kubectl-apply manifest helm_release_naming (#5438)
038146a
@dependabot
Bump cryptography from 46.0.6 to 46.0.7 in /community/front-end/ofe
2948c4f 
Bumps [cryptography](https://github.com/pyca/cryptography) from 46.0.6 to 46.0.7.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@46.0.6...46.0.7)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-version: 46.0.7
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@kadupoornima
Revert "[Telemetry] Set up a base skeleton framework" (#5471)
39a9ab7
@kadupoornima
Revert "Modify the kubectl-apply manifest helm_release_naming" (#5472)
acb697b
@aslam-quad
Merge V1.87.0 into Develop (#5470)
fc4e4d6
@dependabot
Bump django from 6.0.3 to 6.0.4 in /community/front-end/ofe
3e32d39 
Bumps [django](https://github.com/django/django) from 6.0.3 to 6.0.4.
- [Commits](django/django@6.0.3...6.0.4)

---
updated-dependencies:
- dependency-name: django
  dependency-version: 6.0.4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@kadupoornima
[Telemetry] Set up a base skeleton framework - Resubmit (#5475)
89192f7
@agrawalkhushi18
Reapply "Modify the kubectl-apply manifest helm_release_naming (#5438)…
916458f 
…" (#5473)
@aslam-quad
Remove duplicate google-cloud-scret-manager dependency
653c8ab
@cboneti
feat: Automatically add ghpc_creator label to expanded blueprint
8e7bfbe 
Adds --add-creator-label flag to gcluster expand/create/deploy.

Detects username via gcloud auth list or shell environment.

Defaults to true for @google.com accounts.
@cboneti
feat: Automatically add ghpc_creator label to expanded blueprint (#5468)
154149d
@aslam-quad
Bump django from 6.0.3 to 6.0.4 in /community/front-end/ofe (#5465)
61bfcbe
@aslam-quad
Remove duplicate google-cloud-secret-manager dependency (#5477)
238aa0b
@aslam-quad
Bump cryptography from 46.0.6 to 46.0.7 in /community/front-end/ofe (#…
8bb7fd3 
…5467)
@kadupoornima
[Telemetry] Add Viper-based User config backed by Firestore DB (#5478)
e07b3ea
@SwarnaBharathiMantena
Feat: Implement dynamic machine configurations via Compute Engine API (…
8b0b811 
…#5426)
@kadupoornima
[Telemetry] Add metric implementation to collect flags (#5486)
9f5b081
@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Apr 14, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares the repository for the v1.88.0 release. It introduces significant enhancements to the toolkit's infrastructure, including a new telemetry system for usage analytics, improved machine configuration handling for compute modules, and more robust Helm release management. Additionally, it includes updates to CI/CD test playbooks and minor dependency updates.

Highlights

  • Release v1.88.0: Updated versioning across all modules and core configuration to v1.88.0.
  • Machine Configuration Injection: Added a new machine_configs input to compute modules, allowing automatic injection of machine type definitions (GPUs/TPUs/CPUs) into module settings.
  • Telemetry System: Implemented a new telemetry package to collect and upload CLI usage metrics to Google's Clearcut infrastructure.
  • Creator Labeling: Added functionality to automatically label blueprints with the creator's username, defaulting to true for @google.com accounts.
  • Kubectl Apply Improvements: Refactored Helm release naming in the kubectl-apply module to be deterministic and stable, removing the dependency on random_id.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 14, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Cluster Toolkit to version v1.88.0, introducing a telemetry system for usage metrics, user configuration management via Firestore, and automated injection of creator labels and machine configurations. It also refactors the kubectl-apply module for deterministic Helm release names and adds support for GKE auto-monitoring scopes. Feedback highlights the need to respect user privacy settings in the telemetry execution, optimize blueprint parsing to reduce overhead during command execution, and refactor duplicated logic in benchmark scripts to improve maintainability.

Comment thread pkg/telemetry/telemetry.go
Comment thread pkg/telemetry/collector_util.go
Comment thread examples/machine-learning/a4-highgpu-8g/system_benchmarks/run-nccl-tests-via-ramble.sh
@siddhartha-quad siddhartha-quad marked this pull request as ready for review April 15, 2026 11:19
@siddhartha-quad siddhartha-quad requested review from a team and samskillman as code owners April 15, 2026 11:19
@siddhartha-quad siddhartha-quad merged commit 120a933 into main Apr 16, 2026
81 of 93 checks passed
@aslam-quad aslam-quad deleted the release-candidate branch April 16, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@kadupoornima kadupoornima kadupoornima approved these changes

@samskillman samskillman Awaiting requested review from samskillman

@saara-tyagi27 saara-tyagi27 Awaiting requested review from saara-tyagi27

@AdarshK15 AdarshK15 Awaiting requested review from AdarshK15

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.