Skip to content

Adding A4X Integration Test#5487

Merged
LAVEEN merged 4 commits into
GoogleCloudPlatform:developfrom
LAVEEN:a4xtest
Apr 14, 2026
Merged

Adding A4X Integration Test#5487
LAVEEN merged 4 commits into
GoogleCloudPlatform:developfrom
LAVEEN:a4xtest

Conversation

@LAVEEN

@LAVEEN LAVEEN commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This Pull Request adds a new integration test for the A4X HighGPU Slurm blueprint within the Cluster Toolkit. It introduces the necessary Cloud Build and Ansible configurations to automate the validation of machine learning clusters using NVIDIA GB200 resources.

Note: NCCL tests are currently skipped as they require Ramble.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@LAVEEN LAVEEN added the release-chore To not include into release notes label Apr 13, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new integration test suite for A4X high-GPU Slurm configurations within the HPC Toolkit. It includes the necessary build orchestration and test definition files to automate the validation of these deployments, while explicitly excluding NCCL tests for the time being.

Highlights

  • New Integration Test: Added a new integration test configuration for A4X high-GPU Slurm clusters.
  • Cloud Build Configuration: Introduced a new Cloud Build YAML file to orchestrate the A4X integration test execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 13, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new daily integration test for the ml-a4x-highgpu-slurm configuration. It includes a Cloud Build YAML file to orchestrate the test environment, including binary preparation and blueprint modification, and an Ansible variables file defining the test parameters, partitions, and deployment settings. I have no feedback to provide.

@LAVEEN LAVEEN marked this pull request as ready for review April 14, 2026 01:28
@LAVEEN LAVEEN requested review from a team and samskillman as code owners April 14, 2026 01:28
@LAVEEN

LAVEEN commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

[Success] https://pantheon.corp.google.com/cloud-build/builds/b2673f73-8c38-41c9-923f-de125d4dc247?project=hpc-toolkit-dev&e=-13802955&mods=monitoring_api_prod

@LAVEEN LAVEEN merged commit 7c261fe into GoogleCloudPlatform:develop Apr 14, 2026
19 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdarshK15 AdarshK15 AdarshK15 approved these changes

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LAVEEN @AdarshK15 @kvenkatachala333