[Telemetry] Add metric implementation to collect flags #5486
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the telemetry collection mechanism by capturing the command-line flags provided during execution. By integrating with the pflag library, the system now tracks which flags were explicitly set by the user, providing better visibility into how the tool is being utilized. The changes include updates to the core telemetry collector and comprehensive unit tests to ensure accuracy. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the collection of command-line flags in telemetry data. It adds a getCmdFlags function to extract set flags from a cobra.Command and updates the telemetry collector and associated tests to support this new metric. Feedback was provided to improve the efficiency of the getCmdFlags function by pre-allocating the slice used to store flag names based on the number of flags set.
9f5b081
into
GoogleCloudPlatform:develop
This PR enhances Cluster Toolkit Telemetry by capturing the command-line flags provided during CLI commands. Now we can track which flags were explicitly set by the user, providing better visibility into how the tool is being utilized.
Changes:
getCmdFlagsto extract and format active flags from the cobra command.KINDLY NOTE THAT TELEMETRY DATA IS NOT BEING COLLECTED YET.