Skip to content

Revert "Modify the kubectl-apply manifest helm_release_naming"#5472

Merged
kadupoornima merged 1 commit into
developfrom
revert-5438-release-name
Apr 9, 2026
Merged

Revert "Modify the kubectl-apply manifest helm_release_naming"#5472
kadupoornima merged 1 commit into
developfrom
revert-5438-release-name

Conversation

@kadupoornima

@kadupoornima kadupoornima commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Reverts #5438

@kadupoornima kadupoornima requested review from a team and samskillman as code owners April 9, 2026 06:34
@saara-tyagi27 saara-tyagi27 added the release-chore To not include into release notes label Apr 9, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous modification to the kubectl-apply module's Helm release naming convention. It restores the use of a random ID suffix for Helm release names, which helps prevent naming collisions when multiple module instances are deployed simultaneously. This change simplifies the manifest application process by removing the need for deterministic naming logic and associated input fields, ensuring more robust and conflict-free deployments.

Highlights

  • Helm Release Naming Reverted: The Helm release naming strategy has been reverted to use a random ID suffix, preventing name collisions when multiple module instances are deployed simultaneously.
  • Simplified Manifest Input: The name field has been removed from the apply_manifests input, along with its associated validation, simplifying the manifest configuration.
  • Module ID Removal: The module_id variable and its injection mechanism have been removed, streamlining the module's internal logic.
  • Random Provider Added: The random Terraform provider has been added to support the generation of unique suffixes for Helm releases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@kadupoornima kadupoornima enabled auto-merge (squash) April 9, 2026 06:35
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the deterministic Helm release naming logic in the kubectl-apply module with a combination of a random_id suffix and the manifest's list index. It removes the name attribute from the apply_manifests input and the module_id variable, while adding the random provider. Feedback indicates that using list indices for resource keys is a Terraform anti-pattern, as it causes unnecessary resource recreation when the list order changes, and recommends reverting to deterministic naming based on manifest properties.

Comment thread modules/management/kubectl-apply/main.tf
@kadupoornima kadupoornima merged commit acb697b into develop Apr 9, 2026
17 of 76 checks passed
@Neelabh94 Neelabh94 deleted the revert-5438-release-name branch April 30, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arpit974 arpit974 arpit974 approved these changes

@saara-tyagi27 saara-tyagi27 saara-tyagi27 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kadupoornima @arpit974 @saara-tyagi27