Skip to content

Reapply "Modify the kubectl-apply manifest helm_release_naming (#5438)"#5473

Merged
agrawalkhushi18 merged 1 commit into
GoogleCloudPlatform:developfrom
agrawalkhushi18:helm_release_name
Apr 9, 2026
Merged

Reapply "Modify the kubectl-apply manifest helm_release_naming (#5438)"#5473
agrawalkhushi18 merged 1 commit into
GoogleCloudPlatform:developfrom
agrawalkhushi18:helm_release_name

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

This reverts commit 343c79f.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@agrawalkhushi18 agrawalkhushi18 requested review from a team and samskillman as code owners April 9, 2026 07:36
@gemini-code-assist

gemini-code-assist Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reintroduces changes to standardize and improve the naming convention for Helm releases managed by the kubectl-apply module. The primary goal is to make Helm release names more predictable and identifiable by moving away from random suffixes to a deterministic naming hierarchy. This change enhances clarity and manageability for users deploying manifests, while also streamlining the module by removing an unnecessary dependency.

Highlights

  • Deterministic Helm Release Naming: The module now generates deterministic Helm release names based on a precedence hierarchy: explicit name field, file basename, or a fallback to ${module_id}-raw-${hash}. This replaces the previous random suffix approach.
  • Removal of Random Provider: The random Terraform provider and its associated random_id resource have been removed, as they are no longer needed for generating unique release suffixes.
  • New name Field for Manifests: A new optional name attribute has been added to the apply_manifests list object, allowing users to explicitly define Helm release names. A validation rule ensures this name does not exceed 44 characters.
  • Module ID Injection: A module_id variable is now injected into the module, providing a consistent identifier for fallback naming scenarios.
  • Documentation Update: The README.md has been updated to reflect the new Helm release naming strategy and the removal of the random provider.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Helm release name generation logic in the kubectl-apply module to use a deterministic naming scheme instead of a random suffix. This involves introducing a name field in apply_manifests, extracting names from file basenames, or falling back to a module ID and manifest hash, and removing the random Terraform provider dependency. The README.md has been updated to describe this new logic, and input validation for the name field has been added. A review comment suggests rephrasing the description of the deterministic name generation in the README.md for improved clarity and correctness.

Comment thread modules/management/kubectl-apply/README.md
@agrawalkhushi18 agrawalkhushi18 added release-improvements Added to release notes under the "Improvements" heading. release-breaking-changes Prevents "smooth" re-deploy across versions labels Apr 9, 2026
kadupoornima
kadupoornima approved these changes Apr 9, 2026
View reviewed changes

@kadupoornima kadupoornima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving resubmit PR.

@agrawalkhushi18 agrawalkhushi18 requested a review from a team April 9, 2026 09:04
@agrawalkhushi18 agrawalkhushi18 merged commit 916458f into GoogleCloudPlatform:develop Apr 9, 2026
17 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kadupoornima kadupoornima kadupoornima approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-breaking-changes Prevents "smooth" re-deploy across versions release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agrawalkhushi18 @kadupoornima