Skip to content

Update ramble NCCL scripts to be fully noninteractive#5480

Merged
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
RachaelSTamakloe:fix_ramble_nccl
Apr 14, 2026
Merged

Update ramble NCCL scripts to be fully noninteractive#5480
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
RachaelSTamakloe:fix_ramble_nccl

Conversation

@RachaelSTamakloe

@RachaelSTamakloe RachaelSTamakloe commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Update slurm ramble a4h, a4x-high, a4x-max NCCL scripts to be fully noninteractive

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe requested review from a team and samskillman as code owners April 10, 2026 15:02
@github-actions github-actions Bot added the external PR from external contributor label Apr 10, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of automated NCCL benchmark scripts by ensuring that prerequisite installations are fully non-interactive. By managing the Munge service lifecycle and configuring apt-get options, the scripts now avoid common pitfalls related to service locks and interactive configuration prompts during deployment.

Highlights

  • Service Management: Added logic to safely stop and restart the Munge service during package installation to prevent potential file lock conflicts.
  • Non-interactive Installation: Updated apt-get commands to use the non-interactive frontend and forced configuration defaults to ensure automated execution without user prompts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@RachaelSTamakloe RachaelSTamakloe added the release-chore To not include into release notes label Apr 10, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 10, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates NCCL test scripts to handle Munge service conflicts during package installation by stopping the service before running apt-get and restarting it afterward. The review feedback identifies logic issues where the service might be started unnecessarily or left stopped upon failure, and suggests tracking the initial service state and removing inconsistent step numbering.

Comment thread examples/machine-learning/a4-highgpu-8g/system_benchmarks/run-nccl-tests-via-ramble.sh Outdated
Comment thread examples/machine-learning/a4x-highgpu-4g/system_benchmarks/run-nccl-tests-via-ramble.sh Outdated
Comment thread examples/machine-learning/a4x-maxgpu-4g-metal/system_benchmarks/run-nccl-tests-via-ramble.sh Outdated
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Apr 13, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RachaelSTamakloe please ensure that these changes are tested.

@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 35e1172 into GoogleCloudPlatform:develop Apr 14, 2026
17 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@parulbajaj01 parulbajaj01 parulbajaj01 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@SwarnaBharathiMantena SwarnaBharathiMantena

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RachaelSTamakloe @SwarnaBharathiMantena @parulbajaj01