Add DRANET support in Cluster Toolkit by FIoannides · Pull Request #5418 · GoogleCloudPlatform/cluster-toolkit

FIoannides · 2026-03-27T12:13:43Z

Automatically enabled automated networking for supported GPUs and TPUs (https://docs.cloud.google.com/kubernetes-engine/docs/how-to/config-auto-net-for-accelerators#limitations)

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

Fork your PR branch from the Toolkit "develop" branch (not main)
Test all changes with pre-commit in a local branch #
Confirm that "make tests" passes all tests
Add or modify unit tests to cover code changes
Ensure that unit test coverage remains above 80%
Update all applicable documentation
Follow Cluster Toolkit Contribution guidelines #

- Add major/minor version checking to ensure robustness (GKE >= 1.34.1) - Restrict DRANET automatic enablement to specific hardware architectures (A3/A4/CT6E) - Add validation block to enforce hardware and GKE version compatibility when DRANET is manually enabled

…works - Prevent automatic DRANET enablement if additional_networks are provided - Add validation check to prevent enable_dranet=true alongside additional_networks - Bypass minimum additional networks check when DRANET is actively managing network profiles

gemini-code-assist · 2026-03-27T12:13:53Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for DRANET within the GKE node pool module. It adds the necessary configuration parameters and logic to enable automated networking for supported accelerator-optimized machine types, ensuring that the feature is correctly applied based on GKE version compatibility and machine type requirements.

Highlights

DRANET Support: Added support for GKE managed Dynamic Resource Allocation (DRA) driver for networking (DRANET) and Accelerator Network Profile (ANP).
Automated Configuration: Implemented logic to automatically enable DRANET for supported GPU/TPU nodes on compatible GKE versions (1.34.1-gke.1829001 or later).
Validation Checks: Introduced Terraform checks to ensure DRANET requirements are met and to prevent conflicts with additional network configurations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces support for GKE managed Dynamic Resource Allocation (DRA) for networking (DRANET) and Accelerator Network Profiles (ANP) in the GKE node pool module. Changes include a new enable_dranet variable, automatic enablement logic based on GKE version and machine type compatibility, and validation checks to prevent configuration conflicts. Feedback suggests improving documentation consistency in the README and refactoring the version comparison logic in gpu_direct.tf for better readability by extracting version components into local variables.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…atible for better readability

SwarnaBharathiMantena · 2026-04-08T02:26:25Z

/gcbrun

SwarnaBharathiMantena · 2026-04-21T09:54:14Z

/gcbrun

…upport

SwarnaBharathiMantena · 2026-04-22T16:18:03Z

/gcbrun

…compare module

SwarnaBharathiMantena · 2026-04-23T08:11:37Z

/gcbrun

SwarnaBharathiMantena

LGTM!

SwarnaBharathiMantena · 2026-04-27T09:45:31Z

/gcbrun

SwarnaBharathiMantena

LGTM!

FIoannides added 2 commits March 27, 2026 10:49

github-actions Bot added the external PR from external contributor label Mar 27, 2026

gemini-code-assist Bot reviewed Mar 27, 2026

View reviewed changes

Comment thread modules/compute/gke-node-pool/README.md Outdated

Comment thread modules/compute/gke-node-pool/gpu_direct.tf Outdated

FIoannides and others added 3 commits March 27, 2026 12:18

refactor(gke-node-pool): use startswith for a3 and a4 machine families

9a2e3d0

Apply suggestions from code review

97c1a96

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

refactor(gke-node-pool): extract version components in is_dranet_comp…

10a768e

…atible for better readability

FIoannides marked this pull request as ready for review March 27, 2026 14:03

FIoannides requested review from a team and samskillman as code owners March 27, 2026 14:03

SwarnaBharathiMantena reviewed Apr 2, 2026

View reviewed changes

Comment thread modules/compute/gke-node-pool/main.tf

Comment thread modules/compute/gke-node-pool/main.tf

SwarnaBharathiMantena added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Apr 8, 2026

agrawalkhushi18 reviewed Apr 16, 2026

View reviewed changes

Comment thread modules/compute/gke-node-pool/main.tf Outdated

agrawalkhushi18 requested changes Apr 16, 2026

View reviewed changes

feat(gke-node-pool): add TPU7X support to DRANET enablement

7f3e31d

SwarnaBharathiMantena reviewed Apr 22, 2026

View reviewed changes

Comment thread modules/compute/gke-node-pool/gpu_direct.tf Outdated

Merge remote-tracking branch 'upstream/develop' into feature/dranet-s…

9baf9e5

…upport

FIoannides force-pushed the feature/dranet-support branch from a52543f to 199413a Compare April 22, 2026 16:04

refactor(gke-node-pool): simplify version checking logic with semver_…

dfded64

…compare module

FIoannides force-pushed the feature/dranet-support branch from 199413a to dfded64 Compare April 23, 2026 07:02

SwarnaBharathiMantena approved these changes Apr 23, 2026

View reviewed changes

SwarnaBharathiMantena self-requested a review April 24, 2026 08:21

SwarnaBharathiMantena requested changes Apr 24, 2026

View reviewed changes

Comment thread modules/compute/gke-node-pool/main.tf Outdated

FIoannides force-pushed the feature/dranet-support branch from 0df7565 to 3be5df8 Compare April 24, 2026 10:12

feat(gke-node-pool): require Dataplane V2 for DRANET auto-enablement

24bea5b

FIoannides force-pushed the feature/dranet-support branch from 3be5df8 to 24bea5b Compare April 27, 2026 08:26

SwarnaBharathiMantena requested review from SwarnaBharathiMantena and agrawalkhushi18 April 28, 2026 04:49

SwarnaBharathiMantena approved these changes Apr 28, 2026

View reviewed changes

agrawalkhushi18 approved these changes Apr 28, 2026

View reviewed changes

SwarnaBharathiMantena added release-key-new-features Added to release notes under the "Key New Features" heading. and removed release-module-improvements Added to release notes under the "Module Improvements" heading. labels Apr 28, 2026

SwarnaBharathiMantena merged commit 95b778a into GoogleCloudPlatform:develop Apr 28, 2026
32 of 77 checks passed

Conversation

FIoannides commented Mar 27, 2026

Submission Checklist

Uh oh!

gemini-code-assist Bot commented Mar 27, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SwarnaBharathiMantena commented Apr 8, 2026

Uh oh!

Uh oh!

SwarnaBharathiMantena commented Apr 21, 2026

Uh oh!

Uh oh!

SwarnaBharathiMantena commented Apr 22, 2026

Uh oh!

SwarnaBharathiMantena commented Apr 23, 2026

Uh oh!

SwarnaBharathiMantena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SwarnaBharathiMantena commented Apr 27, 2026

Uh oh!

SwarnaBharathiMantena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants