Skip to content

[Telemetry] Add support to collect modules used in blueprint#5534

Merged
kadupoornima merged 7 commits into
GoogleCloudPlatform:developfrom
kadupoornima:telemetry-12
Apr 21, 2026
Merged

[Telemetry] Add support to collect modules used in blueprint#5534
kadupoornima merged 7 commits into
GoogleCloudPlatform:developfrom
kadupoornima:telemetry-12

Conversation

@kadupoornima

@kadupoornima kadupoornima commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request introduces telemetry support for tracking modules utilized within blueprints. It includes logic to identify and categorize modules as either standard (based on the official toolkit release) or custom, ensuring that sensitive or proprietary module paths are not exposed while still providing visibility into usage patterns.

Changes:

  • Module Telemetry: Added functionality to collect and report the modules used in a blueprint as part of the telemetry data.
  • GitHub API Integration: Implemented a mechanism to fetch the list of official predefined modules from the GitHub repository to distinguish between standard and custom modules.
  • Refactoring: Renamed GetAllModules to GetAllBpModules to improve clarity and consistency across the codebase.

KINDLY NOTE THAT TELEMETRY DATA IS NOT BEING COLLECTED YET.

@gemini-code-assist

gemini-code-assist Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces telemetry support for tracking modules utilized within blueprints. It includes logic to identify and categorize modules as either standard (based on the official toolkit release) or custom, ensuring that sensitive or proprietary module paths are not exposed while still providing visibility into usage patterns.

Highlights

  • Module Telemetry: Added functionality to collect and report the modules used in a blueprint as part of the telemetry data.
  • GitHub API Integration: Implemented a mechanism to fetch the list of official predefined modules from the GitHub repository to distinguish between standard and custom modules.
  • Refactoring: Renamed GetAllModules to GetAllBpModules to improve clarity and consistency across the codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 20, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces telemetry for tracking modules used in blueprints by fetching a list of official modules from the GitHub API. Key changes include renaming GetAllModules to GetAllBpModules, implementing the GetPredefinedModules function, and updating the telemetry collector. Feedback focuses on a critical issue where a synchronous network request is made while holding a mutex lock, which could block operations. Additionally, the reviewer noted that errors from the GitHub API are currently ignored and suggested optimizations for the getBpModulesList function to reduce unnecessary allocations.

Comment thread pkg/config/config.go Outdated
Comment thread pkg/telemetry/collector.go Outdated
Comment thread pkg/telemetry/collector_util.go
@kadupoornima kadupoornima added the release-improvements Added to release notes under the "Improvements" heading. label Apr 21, 2026
@kadupoornima kadupoornima marked this pull request as ready for review April 21, 2026 07:03
@kadupoornima kadupoornima requested a review from a team as a code owner April 21, 2026 07:03
@kadupoornima kadupoornima enabled auto-merge (squash) April 21, 2026 07:08
SwarnaBharathiMantena
SwarnaBharathiMantena reviewed Apr 21, 2026
View reviewed changes
Comment thread pkg/config/config.go
Comment thread pkg/config/config.go
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Apr 21, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

auto-merge was automatically disabled April 21, 2026 09:59

Repository rule violations found

@kadupoornima kadupoornima merged commit 86600d1 into GoogleCloudPlatform:develop Apr 21, 2026
16 of 81 checks passed
@kadupoornima kadupoornima deleted the telemetry-12 branch May 22, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@agrawalkhushi18 agrawalkhushi18 Awaiting requested review from agrawalkhushi18

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadupoornima @SwarnaBharathiMantena