Skip to content

Use git ls-files for version updates in release-candidate.sh#5498

Merged
aslam-quad merged 3 commits into
GoogleCloudPlatform:developfrom
aslam-quad:update-version-file-path
Apr 23, 2026
Merged

Use git ls-files for version updates in release-candidate.sh#5498
aslam-quad merged 3 commits into
GoogleCloudPlatform:developfrom
aslam-quad:update-version-file-path

Conversation

@aslam-quad

@aslam-quad aslam-quad commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Use git ls-files for version updates in release-candidate.sh
Tested PR: #5508

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@aslam-quad aslam-quad requested review from a team and samskillman as code owners April 14, 2026 12:07
@github-actions github-actions Bot added the external PR from external contributor label Apr 14, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the release candidate creation process by narrowing the scope of automated version string replacements. By limiting the search path for Go files, the script avoids unintended modifications in other parts of the codebase during the release process.

Highlights

  • Path restriction: Updated the git sed command to target specific Go files in pkg/config/ instead of all Go files in the repository.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@aslam-quad aslam-quad marked this pull request as draft April 14, 2026 12:08
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 14, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the release candidate creation script to limit the scope of version string updates in Go files to the pkg/config/ directory. Feedback suggests that this narrowing of scope is risky as it may miss version occurrences in other parts of the repository, such as the cmd/ directory, and recommends reverting to a more inclusive search pattern to ensure consistency.

Comment thread tools/create-release-candidate.sh Outdated
@aslam-quad aslam-quad changed the title changed file path in release-candidate.sh Use git ls-files for version updates in release-candidate.sh Apr 14, 2026
@aslam-quad aslam-quad force-pushed the update-version-file-path branch 2 times, most recently from 78d7c5b to 33f8cbb Compare April 14, 2026 15:01
@aslam-quad aslam-quad force-pushed the update-version-file-path branch from 33f8cbb to fd089bf Compare April 15, 2026 05:23
@aslam-quad aslam-quad marked this pull request as ready for review April 16, 2026 06:43
@aslam-quad aslam-quad added the release-chore To not include into release notes label Apr 16, 2026
@aslam-quad aslam-quad merged commit 04aff08 into GoogleCloudPlatform:develop Apr 23, 2026
13 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

@saara-tyagi27 saara-tyagi27 Awaiting requested review from saara-tyagi27

@AdarshK15 AdarshK15 Awaiting requested review from AdarshK15

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aslam-quad @LAVEEN @Neelabh94