[Telemetry] Add support to collect machine type information#5494
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request extends the Cluster Toolkit Telemetry capabilities by enabling the collection of machine type data from blueprint configurations. It introduces utility functions to traverse blueprint modules and extract relevant settings, ensuring that machine type information is captured alongside existing telemetry metadata. Note that while the collection logic is implemented, the actual telemetry data transmission is not yet active. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request implements telemetry collection for machine types by adding a utility to retrieve all modules from a blueprint and logic to extract machine or node types from compute modules. Feedback suggests optimizing the module filtering process to avoid redundant regex compilation and refactoring the machine type extraction function to follow Go naming conventions and deduplicate results.
ef65112
into
GoogleCloudPlatform:develop
This PR extends the Cluster Toolkit Telemetry capabilities by enabling the collection of machine type data from blueprint configurations. It introduces utility functions to traverse blueprint modules and extract relevant settings, ensuring that machine type information is captured alongside existing telemetry metadata.
Changes:
KINDLY NOTE THAT TELEMETRY DATA IS NOT BEING COLLECTED YET.