Skip to content

Merge from upstream#2

Merged
webber26232 merged 69 commits intowebber26232:masterfrom
scikit-learn:master
Jul 21, 2019
Merged

Merge from upstream#2
webber26232 merged 69 commits intowebber26232:masterfrom
scikit-learn:master

Conversation

@webber26232
Copy link
Copy Markdown
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

francolq and others added 30 commits July 6, 2019 12:02
* Use minimize for lbfgs in logistic regression, huber, neural_network etc...
* DOC fix typo in ColumnTransformer example
rth and others added 28 commits July 17, 2019 22:51
* ENH Adds files

* ENH Adds permutation importance

* RFC Better names

* STY Flake8

* ENH: Adds inspect module

* DOC Adds pre_dispatch

* DOC Adds permutation importance example

* Trigger CI

* BLD Adds inspect to configuration

* RFC Update to only inspect fitted model

* RFC Removes parameters

* ENH: Adds pandas support

* STY Flake8

* DOC Adds new permutation importance example

* ENH Renames module to model_inspection

* DOC Fix links

* DOC Fixes image link

* DOC Fixes image link

* DOC Spelling

* DOC

* TST Fix keyword

* Rework RF Imp vs Perm Imp example (#4)

* WIP

* WIP

* WIP

* DOC Adds multcollinear features example

* WIP

* DOC: Clean up docs

* TST Adds tests for strings

* STY Indent correction

* WIP

* ENH Uses check_X_y

* TST Adds test with strings

* STY Fix

* TST Adds column transformer to test

* CLN Address comments

* CLN Removes import

* TST Adds test with nan

* CLN Removes import

* ENH Parallel

* DOC comments

* ENH Better handling of pandas

* ENH Clear checking of pandas dataframe

* STY Formatting

* ENH Copies in parallel helper

* DOC Adds comments

* BUG Fix copying

* BUG Fix for pandas

* BUG Fix for pandas

* REV

* BLD Trigger CI

* BUG Fix

* BUG Fix

* TST Does this work

* BUG Fixes test

* BUG Fixes test

* BUG Fix

* BUG Fix

* BUG Fix

* STY Fix

* TST Fix

* TST Fix segfault

* CLN Address comments

* CLN Address comments

* ENH Returns a bunch

* STY Flake8

* CLN Renames bunch key

* DOC Updates api

* DOC Updates api

* TST Adds permutation test with linear_regression

* DOC update

* DOC Fix label cutoff

* CLN Address comments

* TST Adds test for random_state effect

* DOC Adds permutation importance

* DOC Adds ogrisel suggestion

* DOC Address guillaumes comments

* DOC Address andreas comments

* DOC Update
The code related to min_weight_leaf is not used anymore.

It was originally introduced in commit 6f335af.
The code is unused since commit 02c0029.
…14263)

* ENH add new metric Tweedie deviance

* More improvements

* A few more fixes

* Fix doctest

* Review comments

* Add common metric tests

* Add what's new entry

* Fix symmetry check in metrics common tests

* Fix test order determinism

* Rename metric to mean_tweedie_deviance

* Address review comments

* Fix test_score_objects.py tests

* Add Poisson and Gamma deviances

* Fix doc link

* Fix typo on what's new

* Fix rst rendering
…dgeCV (#14423)

* Document default value for fit_intercept param for Ridge and RidgeCV

* Replace boolean with bool in docstrings.
@webber26232 webber26232 merged commit 1a57da0 into webber26232:master Jul 21, 2019
webber26232 pushed a commit that referenced this pull request Oct 22, 2020
…scikit-learn#10591)

* Initial add DET curve to classification metrics

* Add DET to exports

* Fix DET-curve doctest errors

- Sample snippet in  model_evaluation documentation was outdated.

* Clarify wording in DET-curve computation

- Align to the wording of ranking module to make it consistent.
- Add correct describtion of input and outputs.
- Update and fix non-existent links

* Beautify DET curve documentation source

- Limit line length to 80 characters.

* Expand DET curve documentation

- Add an example plot to show difference between ROC and DET curves.
- Expand Usage Note section with background information and properties
of DET curves.

* Update DET-curve documentation

- Fix typos and some grammar improvements.
- Use named references to avoid potential conflicts with other sections.
- Remove unneeded references and improved existing ones by using e.g.
using versioned links.

* Select relevant DET points using slice object

* Remove some dubiety from DET curve doc-string

* Add DET curve contributors

* Add tests for DET curves

* Streamline DET test by using parametrization

* Increase verbosity of DET curve error handling

- Explicitly sanity check input before computing a DET curve.
- Add test for perfect scores.
- Adapt indentation style to match the test module.

* Add reference for DET curves in invariance test

* Add automated invariance checks for DET curves

* Resolve merge artifacts

* Make doctest happy

* Fix whitespaces for doctest

* Revert unintended whitespace changes

* Revert unintended white space changes #2

* Fix typos and grammar

* Fix white space in doc

* Streamline test code

* Remove rebase artifacts

* Fix PR link in doc

* Fix test_ranking

* Fix rebase errors

* Fix import

* Bring back newlines

- Swallowed by copy/paste

* Remove uncited ref link

* Remove matplotlib deprecation warning

* Bring back hidden reference

* Add motivation to DET example

* Fix lint

* Add citation

* Use modern matplotlib API

Co-authored-by: Jeremy Karnowski <jeremy.karnowski@gmail.com>
Co-authored-by: Julien Cornebise <julien@cornebise.com>
Co-authored-by: Daniel Mohns <daniel.mohns@zenguard.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.