[MRG] Use return_X_y=True with load_digits where appropriate#14359
Merged
rth merged 2 commits intoscikit-learn:masterfrom Jul 14, 2019
Merged
[MRG] Use return_X_y=True with load_digits where appropriate#14359rth merged 2 commits intoscikit-learn:masterfrom
rth merged 2 commits intoscikit-learn:masterfrom
Conversation
qinhanmin2014
approved these changes
Jul 14, 2019
| digits = datasets.load_digits(n_class=10) | ||
| X = digits.data | ||
| y = digits.target | ||
| X, y = datasets.load_digits(n_class=10, return_X_y=True) |
Member
There was a problem hiding this comment.
n_class=10 seems redundant
Contributor
Author
There was a problem hiding this comment.
@qinhanmin2014 thanks, I removed the n_class parameter.
8254599 to
2f9b6d5
Compare
rth
approved these changes
Jul 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially address #14347 (Use retrun_X_y=True when applicable in examples)
What does this implement/fix? Explain your changes.
Changes the usage of
load_digitsin examples and tests where appropriate.Any other comments?