Skip to content

DOC: Fix OrdinalEncoder's description#14412

Merged
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
chkoar:fix_doc_ordinal_encoder
Jul 19, 2019
Merged

DOC: Fix OrdinalEncoder's description#14412
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
chkoar:fix_doc_ordinal_encoder

Conversation

@chkoar
Copy link
Copy Markdown
Contributor

@chkoar chkoar commented Jul 19, 2019

No description provided.

--------
sklearn.preprocessing.OrdinalEncoder : encode categorical features
using a one-hot or ordinal encoding scheme.
using an ordinal encoding scheme.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
using an ordinal encoding scheme.
Uses an ordinal encoding scheme.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line is a continuation of the above sentence which states:

sklearn.preprocessing.OrdinalEncoder : encode categorical features

So using Uses an ordinal encoding scheme. it will be

sklearn.preprocessing.OrdinalEncoder : encode categorical features Uses an ordinal encoding scheme.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see okay

@qinhanmin2014 qinhanmin2014 merged commit 13b4bef into scikit-learn:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants