Skip to content

Describe classes_ attribute for GaussianNB, MultinomialNB, etc.#14354

Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
alexitkes:alexitkes-naive-bayes
Jul 14, 2019
Merged

Describe classes_ attribute for GaussianNB, MultinomialNB, etc.#14354
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
alexitkes:alexitkes-naive-bayes

Conversation

@alexitkes
Copy link
Copy Markdown
Contributor

@alexitkes alexitkes commented Jul 14, 2019

Partially address #14312

  • GaussianNB [classes_]
    Class labels known to the classifier

  • BernoulliNB [classes_]
    Class labels known to the classifier

  • ComplementNB [classes_]
    Class labels known to the classifier

  • MultinomialNB [classes_]
    Class labels known to the classifier

Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alexitkes
partially fixes will still close the issue automatically when the PR is merged.

@alexitkes
Copy link
Copy Markdown
Contributor Author

alexitkes commented Jul 14, 2019

partially fixes will still close the issue automatically when the PR is merged.

Oh, sorry, I didn't know that. But... why has #14320 been merged properly? A warning was displayed when I started it with "Fixes <issue_number>", but when I wrote "Partially fixes <issue_number>" instead, it disappeared.

Update:

Sorry again, I see - the issue was re-opened.

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit ebf5fa7 into scikit-learn:master Jul 14, 2019
@thomasjpfan
Copy link
Copy Markdown
Member

Thank you! @alexitkes

@alexitkes alexitkes deleted the alexitkes-naive-bayes branch July 14, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants