Skip to content

[MRG] Add link to ColumnTransformer and user guide to make_column_transformer documentation#14279

Merged
glemaitre merged 7 commits intoscikit-learn:masterfrom
getgaurav2:#14127
Jul 12, 2019
Merged

[MRG] Add link to ColumnTransformer and user guide to make_column_transformer documentation#14279
glemaitre merged 7 commits intoscikit-learn:masterfrom
getgaurav2:#14127

Conversation

@getgaurav2
Copy link
Copy Markdown
Contributor

@getgaurav2 getgaurav2 commented Jul 6, 2019

Reference Issues/PRs

Fixes #14127

What does this implement/fix? Explain your changes.

  1. Added link to make_column_transformer section in User guide
  2. Added description for transformer and column(s) in parameter description in make_column_transformer

Any other comments?

@getgaurav2 getgaurav2 changed the title #14127 [MRG] Add link to ColumnTransformer and user guide to make_column_transformer documentation Jul 7, 2019
@getgaurav2 getgaurav2 marked this pull request as ready for review July 7, 2019 02:56
*transformers : tuples of transformers and column selections
*transformers : Tuples
Tuples of the form ( transformer, column(s)) specifying the
transformer objects to be applied to subsets of the data.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transformer objects to be applied to subsets of the data.
transformer objects to be applied to subsets of the data.

boolean mask array or callable
Indexes the data on its second axis. Integers are interpreted as
positional columns, while strings can reference DataFrame columns
by name. A scalar string or int should be used where
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
by name. A scalar string or int should be used where
by name. A scalar string or int should be used where

----------
*transformers : tuples of transformers and column selections
*transformers : Tuples
Tuples of the form ( transformer, column(s)) specifying the
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tuples of the form ( transformer, column(s)) specifying the
Tuples of the form (transformer, column(s)) specifying the

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Thanks @getgaurav2

Parameters
----------
*transformers : tuples of transformers and column selections
*transformers : Tuples
Copy link
Copy Markdown
Member

@glemaitre glemaitre Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*transformers : Tuples
*transformers : tuples

@glemaitre glemaitre self-requested a review July 12, 2019 15:46
@glemaitre
Copy link
Copy Markdown
Member

@getgaurav2 Thanks for your contribution

@glemaitre glemaitre merged commit b27a37a into scikit-learn:master Jul 12, 2019
@getgaurav2 getgaurav2 deleted the #14127 branch August 8, 2019 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add link to ColumnTransformer and user guide to make_column_transformer documentation

4 participants