DOC make_scorer now requires score function to accpet 1d y_pred when needs_proba is True#14318
Merged
glemaitre merged 5 commits intoscikit-learn:masterfrom Jul 19, 2019
Merged
Conversation
…needs_proba is True
schuderer
reviewed
Jul 13, 2019
Co-Authored-By: Andreas Schuderer <schuderer@gmx.de>
Member
Author
|
thanks @schuderer |
Member
Why not both? It does not seem to be an overkilled to mention in the change of behavior, isn't it? |
glemaitre
approved these changes
Jul 18, 2019
Member
glemaitre
left a comment
There was a problem hiding this comment.
A couple of nitpicks, feel free to accept them or not.
LGTM
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Member
Author
thanks for the review, I've updated what's new. |
Member
|
Thanks @qinhanmin2014 |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Jul 24, 2019
…needs_proba is True (scikit-learn#14318)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12848
In #9521, we change the behavior of make_scorer when needs_proba is True and y_true is binary. Previously, we requires score function to accept 2d y_pred (i.e., the output of predict_proba), now we require the score function to accpet 1d y_pred (probability of the positive class).
I think the change is trivial (maybe more reasonable?) and it has been a long time, so I choose to update the doc instead of mention it in what's new.