Skip to content

Update make_scorer docs. Missing information after #9521 PR.#12848

Closed
alien3211 wants to merge 1 commit intoscikit-learn:masterfrom
alien3211:master
Closed

Update make_scorer docs. Missing information after #9521 PR.#12848
alien3211 wants to merge 1 commit intoscikit-learn:masterfrom
alien3211:master

Conversation

@alien3211
Copy link
Copy Markdown

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@adrinjalali
Copy link
Copy Markdown
Member

Thanks for the PR @alien3211 , could you please provide some context, and a minimal example explaining why the change is needed?

@qinhanmin2014
Copy link
Copy Markdown
Member

Thanks @alien3211 I did this without a deprecation cycle because I think it's a bug, but yes, we fail to inform users.

Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please try to make your words simpler and clearer, e.g., a array of ground truth (correct) labels probability estimates seems hard to understand.

Whether score_func requires predict_proba to get probability estimates
out of a classifier.

When using the binary classification for the ``score_func function``,
Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 Dec 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If needs_proba = True, XXX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants