[MRG] TST add more iteration in randomized SVD test#14308
Merged
rth merged 1 commit intoscikit-learn:masterfrom Jul 12, 2019
Merged
[MRG] TST add more iteration in randomized SVD test#14308rth merged 1 commit intoscikit-learn:masterfrom
rth merged 1 commit intoscikit-learn:masterfrom
Conversation
rth
approved these changes
Jul 12, 2019
Member
Author
|
I will run once the CI with different random state to check that this is robust on as well on 32 bits built. |
Member
Author
|
OK It is working also on 32 bits on 1000 different random_state. I am reverting my last commit |
e1922b5 to
44a2e94
Compare
jeremiedbb
approved these changes
Jul 12, 2019
44a2e94 to
32b9fe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got this test failing on some PRs. I tried with 1000 different random state and it failed 12% of the time.
Increasing the number of iterations solved the issue and make it more robust.