DOC AdaboostRegressor do not require the base estimator to support sample weight#14407
Merged
glemaitre merged 3 commits intoscikit-learn:masterfrom Jul 19, 2019
Merged
Conversation
glemaitre
approved these changes
Jul 19, 2019
| Support for sample weighting is required. If ``None``, then | ||
| the base estimator is ``DecisionTreeRegressor(max_depth=3)`` | ||
| If ``None``, then the base estimator is | ||
| ``DecisionTreeRegressor(max_depth=3)``. |
Member
There was a problem hiding this comment.
Suggested change
| ``DecisionTreeRegressor(max_depth=3)``. | |
| :class:`sklearn.tree.DecisionTreeRegressor(max_depth=3)`. |
Member
Author
There was a problem hiding this comment.
will this work? let's see
Member
Author
There was a problem hiding this comment.
this doesn't work @glemaitre because there're some extra parameters
This reverts commit 1085e3a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We sample the training set according to the weight, which is consistent with the reference.