[MRG] Generate emeritus list, add dates, and change sorting#13586
Merged
qinhanmin2014 merged 4 commits intoscikit-learn:masterfrom Jul 13, 2019
Merged
[MRG] Generate emeritus list, add dates, and change sorting#13586qinhanmin2014 merged 4 commits intoscikit-learn:masterfrom
qinhanmin2014 merged 4 commits intoscikit-learn:masterfrom
Conversation
Member
|
i'm not sure that get_dates corresponds to the years we would consider someone to be an active core developer. But I certainly like how this looks |
Member
|
Yeah, for example with myself it says I've been a coredev since 2017 while it's actually been less than a week ^^ It'd be nice also to replace |
Member
|
It's nice to automate this, but at the same time not having correct dates is not ideal. Maybe removing the dates would make it less controversial? |
Member
Author
|
I removed the dates. |
rth
reviewed
Jul 12, 2019
rth
approved these changes
Jul 13, 2019
adrinjalali
approved these changes
Jul 13, 2019
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
A new name in the emeritus list (Brian Holt)? What's happening? @TomDLT
Member
|
Looks like I missed Brian Holt before, he should be on the list. |
qinhanmin2014
approved these changes
Jul 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #13468 with an automatic generation of authors and emeritus tables.
Specifically:
rendered versionrendered version