DOC More notes about the difference between the three base scorers#14358
Merged
qinhanmin2014 merged 3 commits intoscikit-learn:masterfrom Jul 19, 2019
Merged
DOC More notes about the difference between the three base scorers#14358qinhanmin2014 merged 3 commits intoscikit-learn:masterfrom
qinhanmin2014 merged 3 commits intoscikit-learn:masterfrom
Conversation
NicolasHug
approved these changes
Jul 14, 2019
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks, this is definitely useful info.
The doc renderring is bit odd https://64673-843222-gh.circle-artifacts.com/0/doc/modules/generated/sklearn.metrics.make_scorer.html
Also, why not simply add these notes in the parameter docstrings?
LGTM anyway, apart from the formatting issue.
Member
Author
IMO If we put these things in parameter docstring, we split these things everywhere. |
Member
Author
|
The doc renderring is fixed https://64831-843222-gh.circle-artifacts.com/0/doc/modules/generated/sklearn.metrics.make_scorer.html |
glemaitre
requested changes
Jul 18, 2019
Member
glemaitre
left a comment
There was a problem hiding this comment.
A couple of nitpicks. Otherwise LGTM
Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10247
summarize the difference of the three base scorers, though this is not always the case (e.g., when needs_threshold is True, we'll still accept the output of predict_proba when decision_function is not available, but in this case, users can set needs_proba to True instead)