CI Enable parallel builds#14397
Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom Jul 18, 2019
Merged
Conversation
Member
|
For reference, the caching docs are here: https://docs.microsoft.com/en-us/azure/devops/pipelines/caching/?view=azure-devops In another PR, we can explore if we can use ccache to decrease build times. |
Member
Author
|
On master Linux & MacOS builds are 13-16 min, while in this PR they are 12-14min. So it is a bit faster. |
glemaitre
approved these changes
Jul 18, 2019
thomasjpfan
approved these changes
Jul 18, 2019
Member
|
Thank you! @rth |
rth
added a commit
that referenced
this pull request
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As illustrated in #12676 (comment) by @dimrozakis, parallel build does seem to work (despite earlier reports that they weren't).
This attempts to enable those in CI. The typical strategy for multi-core compilation is to use
CPU_CORES + 1to compensate for I/O.Let's see if this helps with run time. I haven't found a way to pass the
-jflag to thesetup.py bdist_wheelsyet (that is used e.g. for Windows builds on Azure).A better improvement would be to use ccache. Caching was just added to Azure Pipelines microsoft/azure-pipelines-yaml#113 but it doesn't sound like it's as good as in Circle CI. Might be worth investigating.
FYI @jeremiedbb @thomasjpfan