Skip to content

Removes redundant parameter assignment in examples#14360

Merged
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
aalva14:remove-redundant-parameter-assignment-in-examples
Jul 14, 2019
Merged

Removes redundant parameter assignment in examples#14360
qinhanmin2014 merged 1 commit intoscikit-learn:masterfrom
aalva14:remove-redundant-parameter-assignment-in-examples

Conversation

@aalva14
Copy link
Copy Markdown
Contributor

@aalva14 aalva14 commented Jul 14, 2019

Reference Issues/PRs

partially address #14351

What does this implement/fix? Explain your changes.

removing redundant parameter assignment in examples

Any other comments?

did not find any redundant cv=5 parameters in the test. Some of them are used to test deprecated error

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aalva14

@qinhanmin2014 qinhanmin2014 merged commit 40b2a6c into scikit-learn:master Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants