Skip to content

fetch_openml make indices unique in returned dataframe#14316

Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
amueller:fix_fech_dataframe
Jul 13, 2019
Merged

fetch_openml make indices unique in returned dataframe#14316
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
amueller:fix_fech_dataframe

Conversation

@amueller
Copy link
Copy Markdown
Member

@amueller amueller commented Jul 12, 2019

I think we should return a dataframe with a consecutive index.

thomasjpfan
thomasjpfan approved these changes Jul 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinhanmin2014 qinhanmin2014 merged commit 03fd26c into scikit-learn:master Jul 13, 2019
@jnothman
Copy link
Copy Markdown
Member

jnothman commented Jul 13, 2019

Openml provides an identifier column often doesn't it?

@qinhanmin2014
Copy link
Copy Markdown
Member

qinhanmin2014 commented Jul 13, 2019

I think the point here is that we're using pd.concat?

test1 = pd.DataFrame({"a":[1, 2]})
test2 = pd.DataFrame({"a":[3, 4]})
print(pd.concat([test1, test2]))

   a
0  1
1  2
0  3
1  4

@amueller
Copy link
Copy Markdown
Member Author

amueller commented Jul 13, 2019

We drop the identifier column afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

+1 more reviewer

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amueller @jnothman @qinhanmin2014 @thomasjpfan