MAINT Pass liblinear X dimensions around as plain ints#14276
Merged
NicolasHug merged 1 commit intoscikit-learn:masterfrom Jul 8, 2019
alexhenrie:dims
Merged
MAINT Pass liblinear X dimensions around as plain ints#14276NicolasHug merged 1 commit intoscikit-learn:masterfrom alexhenrie:dims
NicolasHug merged 1 commit intoscikit-learn:masterfrom
alexhenrie:dims
Conversation
thomasjpfan
approved these changes
Jul 6, 2019
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Matching the interface for csr_set_problem is nice :)
NicolasHug
approved these changes
Jul 8, 2019
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Out of curiosity are you working on these files @alexhenrie ?
Contributor
Author
|
Yes I am working on these files. Once this pull request is merged, I will submit another one that drastically reduces the memory required when the inputs are 32-bit, then I will submit another one that does a bit more cleanup, and then hopefully I'll be done. |
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is much easier to understand, it matches what we're doing in csr_set_problem and csr_to_sparse, and it eliminates the absolutely unnecessary conversion to float64_t.