Skip to content

DOC Correct shape of attibute constant_ in DummyRegressor#14277

Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
qinhanmin2014:DummyRegressor-constant-shape
Jul 6, 2019
Merged

DOC Correct shape of attibute constant_ in DummyRegressor#14277
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
qinhanmin2014:DummyRegressor-constant-shape

Conversation

@qinhanmin2014
Copy link
Copy Markdown
Member

maybe we can change the shape to (n_outputs,)? but it's not an important issue IMO.

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 90b04a3 into scikit-learn:master Jul 6, 2019
alexshacked pushed a commit to alexshacked/scikit-learn that referenced this pull request Jul 6, 2019
@qinhanmin2014 qinhanmin2014 deleted the DummyRegressor-constant-shape branch July 9, 2019 14:16
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants