Skip to content

Add Votings landing page layout#7440

Merged
mrcasals merged 15 commits intodevelopfrom
feat/votings_public_landing_page
Mar 3, 2021
Merged

Add Votings landing page layout#7440
mrcasals merged 15 commits intodevelopfrom
feat/votings_public_landing_page

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Feb 23, 2021 •
edited
Loading

🎩 What? Why?

This PR adds the Landing page layout for votings and is the base for the landing page content blocks.

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@leio10 leio10 added project: e-voting Barcelona City Council contract module: elections labels Feb 23, 2021
@agustibr agustibr mentioned this pull request Feb 23, 2021
Merged
12 tasks
@agustibr agustibr force-pushed the feat/votings_public_landing_page branch from 17a8abb to 6ca484c Compare February 23, 2021 19:53
This was referenced Feb 23, 2021
Merged
Merged
Merged
Merged
Merged
@agustibr agustibr force-pushed the feat/votings_public_landing_page branch from cd45f35 to dc3120a Compare February 25, 2021 07:56
@agustibr agustibr self-assigned this Feb 25, 2021
@agustibr agustibr marked this pull request as ready for review February 25, 2021 15:32
orlera
orlera previously approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 👏

leio10
leio10 previously approved these changes Feb 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agustibr agustibr dismissed stale reviews from leio10 and orlera via 9903d0a February 26, 2021 12:29
@agustibr agustibr force-pushed the feat/votings_public_landing_page branch from 9903d0a to 6292556 Compare February 26, 2021 14:26
@agustibr agustibr mentioned this pull request Feb 26, 2021
Merged
12 tasks
slickepinne
slickepinne previously approved these changes Mar 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

decidim-elections/lib/decidim/votings/participatory_space.rb Outdated
end

Decidim.component_manifests.each do |manifest|
# next unless [:elections].member? manifest.name
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this line get removed?

@mrcasals mrcasals changed the title Votings LandingPage layout Add Votings LandingPage layout Mar 2, 2021
@mrcasals mrcasals changed the title Add Votings LandingPage layout Add Votings landing page layout Mar 2, 2021
@mrcasals mrcasals merged commit f2c92fc into develop Mar 3, 2021
@mrcasals mrcasals deleted the feat/votings_public_landing_page branch March 3, 2021 13:21
entantoencuanto added a commit that referenced this pull request Mar 4, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
f882f10 
* develop:
  Update the workflow cleanup action to the latest version (#7535)
  Don't schedule CI jobs for locales PRs (#7534)
  Fix record encryptor trying to decrypt or decode non-String values (#7536)
  Add Votings landing page to the design app (#7527)
  New Crowdin updates (#7530)
  Fix non-unique IDs element in filter hash cash (#7531)
  New Crowdin updates (#7485)
  Add statistics cell to votings landing page and reuse it in other places (#7413)
  Add Votings landing page layout (#7440)
  Add share modal to budgets (#7519)
  Do not change the global test app configs during specs (#7525)
  Change the order of attachments in budgets (#7524)
  Remove console warnings from the conversations views (#7523)
  Don't allow filtering meetings by user group if setting is disabled (#7514)
  Remove duplicated migration (#7517)
  New Admin users cannot accept Terms and conditions (#7516)
  Let installations delay TranslatorJob initialization (#7507)
  Exit on CI workflow dispatch failures (#7502)
  Invalidate all user sessions when destroying the account (#7506)
  Audit vote (#7442)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beagleknight beagleknight Awaiting requested review from beagleknight

4 more reviewers

@mrcasals mrcasals mrcasals approved these changes

@leio10 leio10 leio10 left review comments

@orlera orlera orlera left review comments

@slickepinne slickepinne slickepinne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@agustibr agustibr

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@agustibr @leio10 @mrcasals @orlera @slickepinne