Skip to content

New Admin users cannot accept Terms and conditions#7516

Merged
mrcasals merged 1 commit intodecidim:developfrom
i-need-another-coffee:fix-anouncement-box
Mar 3, 2021
Merged

New Admin users cannot accept Terms and conditions#7516
mrcasals merged 1 commit intodecidim:developfrom
i-need-another-coffee:fix-anouncement-box

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

As a new Admin, I cannot accept any Terms as the admin does not display any information regarding acceptance of TOS
image

after applying the patch :

image

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Mar 3, 2021

Nice catch, @alecslupu!

This should be backported to 0.24.

@mrcasals mrcasals merged commit f372554 into decidim:develop Mar 3, 2021
@mrcasals mrcasals deleted the fix-anouncement-box branch March 3, 2021 08:28
entantoencuanto added a commit that referenced this pull request Mar 4, 2021
* develop:
  Update the workflow cleanup action to the latest version (#7535)
  Don't schedule CI jobs for locales PRs (#7534)
  Fix record encryptor trying to decrypt or decode non-String values (#7536)
  Add Votings landing page to the design app (#7527)
  New Crowdin updates (#7530)
  Fix non-unique IDs element in filter hash cash (#7531)
  New Crowdin updates (#7485)
  Add statistics cell to votings landing page and reuse it in other places (#7413)
  Add Votings landing page layout (#7440)
  Add share modal to budgets (#7519)
  Do not change the global test app configs during specs (#7525)
  Change the order of attachments in budgets (#7524)
  Remove console warnings from the conversations views (#7523)
  Don't allow filtering meetings by user group if setting is disabled (#7514)
  Remove duplicated migration (#7517)
  New Admin users cannot accept Terms and conditions (#7516)
  Let installations delay TranslatorJob initialization (#7507)
  Exit on CI workflow dispatch failures (#7502)
  Invalidate all user sessions when destroying the account (#7506)
  Audit vote (#7442)
oriolgual pushed a commit that referenced this pull request Mar 5, 2021
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: admin module: budgets type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants