Don't schedule CI jobs for locales PRs#7534
Merged
Conversation
oliverbarnes
approved these changes
Mar 4, 2021
Contributor
oliverbarnes
left a comment
There was a problem hiding this comment.
👌 good idea, should help unclog ci queues. Removing the conditionals cleans up workflow code as well
entantoencuanto
added a commit
that referenced
this pull request
Mar 4, 2021
* develop: Update the workflow cleanup action to the latest version (#7535) Don't schedule CI jobs for locales PRs (#7534) Fix record encryptor trying to decrypt or decode non-String values (#7536) Add Votings landing page to the design app (#7527) New Crowdin updates (#7530) Fix non-unique IDs element in filter hash cash (#7531) New Crowdin updates (#7485) Add statistics cell to votings landing page and reuse it in other places (#7413) Add Votings landing page layout (#7440) Add share modal to budgets (#7519) Do not change the global test app configs during specs (#7525) Change the order of attachments in budgets (#7524) Remove console warnings from the conversations views (#7523) Don't allow filtering meetings by user group if setting is disabled (#7514) Remove duplicated migration (#7517) New Admin users cannot accept Terms and conditions (#7516) Let installations delay TranslatorJob initialization (#7507) Exit on CI workflow dispatch failures (#7502) Invalidate all user sessions when destroying the account (#7506) Audit vote (#7442)
Contributor
Author
|
#7539 is a locales PR that ran after this PR was merged. If you check the CI jobs, you'll see only the ones in Main were scheduled, as expected! 🎉 |
12 tasks
Contributor
Author
|
Well, this seems to break the pipeline for PRs coming from forks. I'm reverting this PR. |
mrcasals
added a commit
that referenced
this pull request
Mar 5, 2021
entantoencuanto
added a commit
that referenced
this pull request
Mar 5, 2021
* develop: Fix infinite loop when impersonated session time runs out (#7221) New Crowdin updates (#7543) Migrate Admin menus to Menu Registry Part 2 (#7382) Replace xls with xlsx (#7421) Use cache_key_with_version instead of cache version (#7532) Add support for ElectionGuard voting scheme (#7454) Fix record encryptor trying to decrypt empty strings (#7542) Revert "Don't schedule CI jobs for locales PRs (#7534)" (#7546) New Crowdin updates (#7540) New Crowdin updates (#7539)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When we get Crowdin updates, we schedule all the CI jobs, even if they're then automatically skipped. This feels weird, since we're scheduling jobs that will be skipped anyway. Also, CI jobs would only be scheduled once the PR is created.
With this approach, we're making sure the CI jobs for Crowdin updates are never even scheduled, and we're running the CI on any push to any branch (instead of waiting for the PR to be created).
📌 Related Issues
None
Testing
I guess you could play with the code any using differnt branch names? Also, #7535 builds on top of this one. Notice how the tests actually run there, but not in this PR, due to the branch names.