Merged
Conversation
ahukkanen
reviewed
Feb 19, 2021
oriolgual
previously approved these changes
Feb 23, 2021
Contributor
oriolgual
left a comment
There was a problem hiding this comment.
Could we test this in a staging environment?
Contributor
|
Can be tested here @decidim/product https://decidim-staging-pr-311.herokuapp.com/ |
Member
|
Tested, thanks for the PR @lahdeero! |
oriolgual
approved these changes
Mar 5, 2021
entantoencuanto
added a commit
that referenced
this pull request
Mar 5, 2021
* develop: Fix infinite loop when impersonated session time runs out (#7221) New Crowdin updates (#7543) Migrate Admin menus to Menu Registry Part 2 (#7382) Replace xls with xlsx (#7421) Use cache_key_with_version instead of cache version (#7532) Add support for ElectionGuard voting scheme (#7454) Fix record encryptor trying to decrypt empty strings (#7542) Revert "Don't schedule CI jobs for locales PRs (#7534)" (#7546) New Crowdin updates (#7540) New Crowdin updates (#7539)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This pull request updates Decidim to newer excel format and because of that, we have to replace spreadsheet gem with rubyXL gem.
📌 Related Issues
https://meta.decidim.org/processes/roadmap/f/122/proposals/14921
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.