Skip to content

Migrate Admin menus to Menu Registry Part 2#7382

Merged
oriolgual merged 19 commits intodecidim:developfrom
i-need-another-coffee:feature/admin-menus-2
Mar 5, 2021
Merged

Migrate Admin menus to Menu Registry Part 2#7382
oriolgual merged 19 commits intodecidim:developfrom
i-need-another-coffee:feature/admin-menus-2

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Feb 14, 2021

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu force-pushed the feature/admin-menus-2 branch from d306fe4 to 4433995 Compare February 14, 2021 22:39
@alecslupu alecslupu changed the title Feature/admin menus 2 Migrate Admin menus to Menu Registry Part 2 Feb 14, 2021
@alecslupu alecslupu force-pushed the feature/admin-menus-2 branch 7 times, most recently from 06eca84 to 3fb9fa6 Compare February 24, 2021 07:19
@alecslupu alecslupu force-pushed the feature/admin-menus-2 branch from 3fb9fa6 to 9db6029 Compare March 2, 2021 23:43
@alecslupu alecslupu mentioned this pull request Mar 3, 2021
12 tasks
@alecslupu alecslupu force-pushed the feature/admin-menus-2 branch from 9db6029 to 5517cbe Compare March 4, 2021 23:44
@alecslupu alecslupu marked this pull request as ready for review March 5, 2021 00:20
@alecslupu alecslupu force-pushed the feature/admin-menus-2 branch from 219ce4b to beb4adf Compare March 5, 2021 00:44
@alecslupu alecslupu force-pushed the feature/admin-menus-2 branch from beb4adf to b121ce9 Compare March 5, 2021 09:22
@oriolgual oriolgual merged commit 4f984f0 into decidim:develop Mar 5, 2021
entantoencuanto added a commit that referenced this pull request Mar 5, 2021
* develop:
  Fix infinite loop when impersonated session time runs out (#7221)
  New Crowdin updates (#7543)
  Migrate Admin menus to Menu Registry Part 2 (#7382)
  Replace xls with xlsx (#7421)
  Use cache_key_with_version instead of cache version (#7532)
  Add support for ElectionGuard voting scheme (#7454)
  Fix record encryptor trying to decrypt empty strings (#7542)
  Revert "Don't schedule CI jobs for locales PRs (#7534)" (#7546)
  New Crowdin updates (#7540)
  New Crowdin updates (#7539)
@alecslupu alecslupu deleted the feature/admin-menus-2 branch July 19, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants