Skip to content

Migrate Admin menus to Menu Registry#7368

Merged
oriolgual merged 7 commits intodecidim:developfrom
i-need-another-coffee:feature/admin-menus
Feb 23, 2021
Merged

Migrate Admin menus to Menu Registry#7368
oriolgual merged 7 commits intodecidim:developfrom
i-need-another-coffee:feature/admin-menus

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Feb 12, 2021 •
edited
Loading

🎩 What? Why?

Migrate Admin menus to Menu Registry to ease out adding menu entries from additional modules.

📌 Related Issues

Link your PR to an issue

Testing

  1. Apply the patch, see menus look the same before.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu force-pushed the feature/admin-menus branch 4 times, most recently from ad4e88b to 17821a1 Compare February 14, 2021 20:52
@alecslupu alecslupu changed the title Add Admin menus of Participatory Process to Menu Registry Migrate Admin menus to Menu Registry Feb 14, 2021
@alecslupu alecslupu marked this pull request as ready for review February 14, 2021 22:39
@alecslupu alecslupu mentioned this pull request Feb 14, 2021
Merged
12 tasks
@oriolgual oriolgual merged commit 033dfc8 into decidim:develop Feb 23, 2021
@alecslupu alecslupu deleted the feature/admin-menus branch February 24, 2021 07:01
@mrcasals mrcasals added module: admin type: change PRs that implement a change for an existing feature labels Feb 24, 2021
entantoencuanto added a commit that referenced this pull request Feb 25, 2021
@entantoencuanto
Merge branch 'develop' into private_participants_share_token
d177144 
* develop: (232 commits)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  Resort Menus (#7460)
  Polling Officer Zone (#7439)
  Fix session timeout when using multiple windows or tabs (#7459)
  Fix display of debates with multiple dates (#7393)
  chore: split election tests (#7451)
  style: make selected values primary labels with delete button (#7448)
  Fix and tests to avoid registered users being invited again (#7392)
  Migrate Admin menus to Menu Registry (#7368)
  New Crowdin updates (#7338)
  Bump to carrierwave 2.2.0 (#7441)
  Voting: show callout when Polling Stations miss Polling Officers (#7417)
  Further default orders for the API (#7436)
  Fix random order inconsistencies (#7437)
  Ensure Rails is locked to 5.2.4.x series (#7430)
  Add default order by ID to API list queries (#7424)
  Update dependencies (#7422)
  Ignore warning on CI when no artifacts to upload (#7420)
  Filter and search polling officers (#7411)
  ...
@alecslupu alecslupu mentioned this pull request Mar 7, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@oriolgual oriolgual oriolgual approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: admin type: change PRs that implement a change for an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alecslupu @oriolgual @mrcasals