Skip to content

Improve menus sorting#7460

Merged
mrcasals merged 4 commits intodecidim:developfrom
CodiTramuntana:chore/menu_ordering
Feb 25, 2021
Merged

Improve menus sorting#7460
mrcasals merged 4 commits intodecidim:developfrom
CodiTramuntana:chore/menu_ordering

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal commented Feb 24, 2021

🎩 What? Why?

Please describe your pull request.
Right now there are some inconsistencies in the prioritization of menu options in the admin menu.

In the admin menu we have a conflict between assemblies and conferences, and between initiatives and votings. Here is the current ordering with the proposed corrections:

  • dashboard, position: 1
  • participatory_processes, position: 2
  • assemblies, position: 3.5 => 2.2
  • initiatives, position: 3.7 => 2.4
  • votings, position: 3.7 => 2.6
  • consultations, position: 3.8 => 2.65
  • conferences, position: 3.5 => 2.8
  • moderation, position: 4
  • static_pages, position: 4.5
  • users, position: 5
  • newsletters, position: 6
  • settings, position: 7
  • admin_log, position: 10
  • templates, position: 12

In the main public menu there's no conflict between options but current sorting for participatory spaces seems that could be improved to follow the same increment between all participatory spaces (leaving the same logical distance between each space):

  • home, position: 1
  • processes, position: 2
  • assemblies, position: 2.5 => 2.2
  • initiatives, position: 2.6 => 2.4
  • votings, position: 2.8 => 2.6
  • consultations, position: 2.8 => 2.65
  • conferences, position: 6 => 2.8
  • help, position: 7

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

Admin menu after rework

imatge

Public menu after rework

imatge

♥️ Thank you!

@tramuntanal tramuntanal marked this pull request as ready for review February 24, 2021 14:52
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mrcasals mrcasals merged commit a408236 into decidim:develop Feb 25, 2021
@mrcasals mrcasals changed the title Resort Menus Improve menus sorting Feb 25, 2021
@tramuntanal tramuntanal deleted the chore/menu_ordering branch February 25, 2021 11:16
entantoencuanto added a commit that referenced this pull request Feb 25, 2021
* develop: (232 commits)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  Resort Menus (#7460)
  Polling Officer Zone (#7439)
  Fix session timeout when using multiple windows or tabs (#7459)
  Fix display of debates with multiple dates (#7393)
  chore: split election tests (#7451)
  style: make selected values primary labels with delete button (#7448)
  Fix and tests to avoid registered users being invited again (#7392)
  Migrate Admin menus to Menu Registry (#7368)
  New Crowdin updates (#7338)
  Bump to carrierwave 2.2.0 (#7441)
  Voting: show callout when Polling Stations miss Polling Officers (#7417)
  Further default orders for the API (#7436)
  Fix random order inconsistencies (#7437)
  Ensure Rails is locked to 5.2.4.x series (#7430)
  Add default order by ID to API list queries (#7424)
  Update dependencies (#7422)
  Ignore warning on CI when no artifacts to upload (#7420)
  Filter and search polling officers (#7411)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants